Open Stack

On 08/18/2016 03:31 PM, Matthew Thode wrote:
> On 08/18/2016 01:50 PM, Matt Riedemann wrote:
>> On 8/18/2016 1:18 PM, Matthew Thode wrote:
>>> Perhaps a better option would be to get oslo.db to run cross-project
>>> checks like we do in requirements.  That way the right team is covering
>>> the usage of postgres and we still have coverage while still lowering
>>> gate load for most projects.
>>>
>>>
>>>
>>> __________________________________________________________________________
>>>
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>> I don't see the value in this unless there are projects that have
>> pg-specific code in them. The reason we have cross-project unit test
>> jobs for reqs changes is requirements changes in upper-constraints can
>> break and wedge the gate for a project, or multiple project. E.g.
>> removing something in a backward incompatible way, or the project with
>> the unit test is mocking something out poorly (like we've seen lately
>> with nova and python-neutronclient releases).
>>
> 
> That makes sense, just improving the oslo.db test coverage for postgres
> (if that's even necessary) would be good.  The only other thing I'd like
> to see (and it may already be done) is to have pg upgrade test coverage,
> aka, I don't want to hit that keystone bug again :P  But that's a
> different conversation.

That's entirely doable inside the project. We do that in nova in our
unit tests. The important thing there is to not just run the schema
upgrades, but do them with some representative data in the tables.

	-Sean

-- 
Sean Dague
http://dague.net