Open Stack

On Mon, Aug 01, 2016 at 03:53:12PM +0000, Lenny Verkhovsky wrote:
> Hi,
> 
> Currently in some cases[1] CI sets a comment on the patch set as NOT_REGISTERED.
> 
> Those comments are very hard to monitor for CI operators and have noisy value for the developers.
> 
> Maybe a better solution is not commenting in such cases at all as discussed in [2].
> 
> If a developer is missing some important CI comments, it can rechecked later or sent an email to CI owner.
> 
> [1] No valid slaves
>        Not all jobs are registered due to zuul restart for instance
> 
> [2] http://eavesdrop.openstack.org/irclogs/%23openstack-meeting/%23openstack-meeting.2016-08-01.log.html
> 
We actually disabled this functionality in openstack-infra by adding a new
setting to zuul called check_job_registration[3]. While it doesn't address the
issue of invalid job configuration from landing in zuul, it does prevent
NOT_REGISTERED in the gate now.

We, openstack-infra, make every effort in our gate testing to ensure each change
to jenkins/jobs and zuul/layout.yaml is actually valid, if not zuul with -1 the
change as invalid. In our case, having zuul then check for registered jobs, was
a little redundant.

Now, changes land, zuul skips checking if the jobs are valid, and waits for new
nodes to come online. It also is less disruptive to testing when we have to
restart zuul, since jobs does fail with NOT_REGISTERED.

The downside of course, if a job is not configured properly, it will linger in
the queue until somebody address the issue.

[3] http://git.openstack.org/cgit/openstack-infra/zuul/commit/?id=9208dc1c0a859642deece4f4be5f43fae065c945