[openstack-dev] [ironic] [api] Fixing bugs in old microversions

Dmitry Tantsur dtantsur at redhat.com
Mon Apr 11 13:48:48 UTC 2016


On 04/11/2016 02:00 PM, Jay Pipes wrote:
> On 04/11/2016 04:48 AM, Vladyslav Drok wrote:
>> Hi all!
>>
>> There is a bug <https://bugs.launchpad.net/ironic/+bug/1565663> in
>> ironic API that allows to remove node name using any API version,
>> while node names were added in version 1.5. There are concerns that
>> fixing this might
>> be a breaking change, and I'm not sure how to proceed with that. Here is
>> a change <https://review.openstack.org/300983> that
>> fixes the bug by just forbidding to do PATCH remove request on /name
>> path if requested
>> API version is less than 1.5. Is it enough to just mention this in a
>> release note, maybe
>> both in fixes and upgrade sections? As bumping API microversion to fix
>> some previous
>> microversion seems weird to me.
>>
>> Any suggestions?
>
> I think the approach you've taken -- just fix it and not add a new
> microversion -- is the correct approach.

Do we really allow breaking API changes, covering old microversions?

>
> Best,
> -jay
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




More information about the OpenStack-dev mailing list