Open Stack

> So should we add what we don't want
to see people -1 for?

>[1] http://docs.openstack.org/infra/manual/developers.html#peer-review

This seems right way.. but concern is do everyone follow all docs?

But atleast we should document it somewhere.

Regards,
Sheel Rana
On Apr 11, 2016 6:52 AM, "Masayuki Igawa" <masayuki.igawa at gmail.com> wrote:

2016-04-11 9:46 GMT+09:00 Matt Riedemann <mriedem at linux.vnet.ibm.com>:
>
>
> On 4/10/2016 6:37 PM, Clint Byrum wrote:
>>
>> Excerpts from Matt Riedemann's message of 2016-04-09 06:42:54 -0700:
>>>
>>> There is also disincentive in +1ing a change that you don't understand
>>> and is wrong and then a core comes along and -1s it (you get dinged for
>>> the disagreement). And there is disincentive in -1ing a change for the
>>> wrong reasons (silly nits or asking questions for understanding). I ask
>>> a lot of questions in a lot of changes and I don't vote on those because
>>> it would be inappropriate.
>>>
>>
>> Why is disagreement a negative thing? IMO, reviewers who agree too much
>> are just part of the echo chamber.
>>
>>
__________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
> I'm not saying disagreement is a negative thing, I was saying there are
> times when I've seen people -1 for crazy nits, e.g. there should be a
blank
> line between the bug ref and change-id in the commit message, or for
asking
> questions for understanding (which, btw, I'm fine with -1 for 'add a
comment
> because this is complicated and I didn't get it at first'). And I'm also
not
> crazy about piling on or agreeing with everything either. My point is I
> think it's appropriate in a lot of cases to just not vote but still
comment.

I think we have some/many implicit rules for our review. There's a
document[1] for review
but it doesn't mention crazy nits. So should we add what we don't want
to see people -1 for?

[1] http://docs.openstack.org/infra/manual/developers.html#peer-review

>
> --
>
> Thanks,
>
> Matt Riedemann
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160411/c94eea7b/attachment.html>