Open Stack

Li Yong,

At any rate, this should not be hardcoded. I agree that the default value should match the RPC timeout.

Adrian

> On Nov 24, 2015, at 11:23 PM, Qiao,Liyong <liyong.qiao at intel.com> wrote:
> 
> hi all
> In Magnum code, we hardcode it as DEFAULT_DOCKER_TIMEOUT = 10
> This bring troubles in some bad networking environment (or bad performance swarm master)
> At least it doesn't work on our gate.
> 
> Here is the test patch on gate https://review.openstack.org/249522 , I set it as 180 to make sure
> the failure it due to time_out parameter passed to docker client, but we need to chose a suitble one
> 
> I check docker client's default value,
> DEFAULT_TIMEOUT_SECONDS = 60 , I wonder why we overwrite it  as 10?
> 
> Please let me know what's your though? My suggestion is we set DEFAULT_DOCKER_TIMEOUT
> as long as our rpc time_out.
> 
> -- 
> BR, Eli(Li Yong)Qiao
> 
> <liyong_qiao.vcf>__________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev