On Thu, May 28, 2015 at 11:55:59AM +0300, Feodor Tersin wrote: > +1 > But we should answer the following question before switching libvirt to > utils.get_image_from_system_metadata. > > Some differences of utils.get_image_from_system_metadata from > compute.utils.get_image_metadata are: > 1) Instance metadata has a restriction of property length: long data is > stripped to 255 chars. > This may cause a fault on loading serialized structure from a metadata > property. > > 2) utils.get_image_from_system_metadata skips properties defined by > CONF.non_inheritable_image_properties > > So the question is: are these facts important for libvirt? compute.utils.get_image_metadata calls utils.get_image_from_system_metadata so those don't cause any difference in behaviour. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|