[openstack-dev] [all] gate pep8 jobs broken today

Joe Gordon joe.gordon0 at gmail.com
Tue May 19 10:54:19 UTC 2015


On May 19, 2015 12:43 AM, "Andreas Jaeger" <aj at suse.com> wrote:
>
> On 05/19/2015 09:28 AM, Andreas Jaeger wrote:
>>
>> On 05/19/2015 02:54 AM, Robert Collins wrote:
>>>
>>> Hi, we had a gate outage today for a few hours.
>>>
>>> http://pad.lv/1456376
>>>
>>> The issue was an interaction between the existence of pbr 1.0, project
>>> local requirements, hacking 0.10.1 and flake8 <2.4.1.
>>>
>>> When flake8< 2.4.1 loads plugins (which hacking is) it uses
>>> pkg_resources and calls load(), which checks requirements.
>>>
>>> pbr in the pep8 jobs is installed by the project requirements.txt
>>> files, which per global-requirements mostly now say ">=0.11, <2.0", so
>>> pbr 1.0.0 was immediately installed once it was released.
>>>
>>> hacking is installed from release, so hacking 0.10.1 was installed,
>>> which has the constraint for pbr of <1.0 that we had prior to bumping
>>> the releases in global-requirements. And so boom.
>>>
>>> We've now released hacking 0.10.2, which contains only the updated pbr
>>> constraint, and we don't expect any additional fallout from it.
>>>
>>> Thanks Clark, Doug, Ian, Sean, and Joe for helping unwind, analyze and
>>> fix this.
>>
>>
>> There are some projects like ironic that pin an old hacking version and
>> thus will not benefit from the new hacking release:
>>
>> hacking>=0.9.2,<0.10
>>
>> They need to update their hacking version [1],
>>
>> Andreas
>>
>> [1] https://review.openstack.org/184198
>
>
> Additional projects in the openstack namespace that might fail pep8 now
due to the pinning of hacking:
>
> castellan/test-requirements.txt:hacking>=0.9.2,<0.10
> congress/test-requirements.txt:hacking>=0.9.2,<0.10
> designate/test-requirements.txt:hacking>=0.9.2,<0.10
> heat-cfntools/test-requirements.txt:hacking>=0.8.0,<0.9
> heat-templates/test-requirements.txt:hacking>=0.8.0,<0.9
> ironic-python-agent/test-requirements.txt:hacking>=0.8.0,<0.9
> keystonemiddleware/test-requirements-py3.txt:hacking>=0.8.0,<0.9
> kite/test-requirements.txt:hacking>=0.9.2,<0.10
> manila/test-requirements.txt:hacking>=0.9.2,<0.10
> murano-agent/test-requirements.txt:hacking>=0.8.0,<0.9
> os-apply-config/test-requirements.txt:hacking>=0.9.2,<0.10
> os-client-config/test-requirements.txt:hacking>=0.9.2,<0.10
> os-cloud-config/test-requirements.txt:hacking>=0.9.2,<0.10
> os-collect-config/test-requirements.txt:hacking>=0.9.2,<0.10
> os-refresh-config/test-requirements.txt:hacking>=0.9.2,<0.10
> python-cinderclient/test-requirements.txt:hacking>=0.8.0,<0.9
> python-congressclient/test-requirements.txt:hacking>=0.9.2,<0.10
> python-designateclient/test-requirements.txt:hacking>=0.9.2,<0.10
> python-glanceclient/test-requirements.txt:hacking>=0.8.0,<0.9
> python-heatclient/test-requirements.txt:hacking>=0.8.0,<0.9
> python-kiteclient/test-requirements.txt:hacking>=0.9.1,<0.10
> python-manilaclient/test-requirements.txt:hacking>=0.9.2,<0.10
> python-muranoclient/test-requirements.txt:hacking>=0.9.2,<0.10
> python-swiftclient/test-requirements.txt:hacking>=0.8.0,<0.9
> python-troveclient/test-requirements.txt:hacking>=0.8.0,<0.9
> python-tuskarclient/test-requirements.txt:hacking>=0.9.2,<0.10
> python-zaqarclient/test-requirements.txt:hacking>=0.8.0,<0.9
> rally/test-requirements.txt:hacking>=0.9.2,<0.10
> swift-bench/test-requirements.txt:hacking>=0.8.0,<0.9
> swift/test-requirements.txt:hacking>=0.8.0,<0.9
> tripleo-image-elements/test-requirements.txt:hacking>=0.9.2,<0.10
> tripleo-puppet-elements/test-requirements.txt:hacking>=0.8.0,<0.9
> trove/test-requirements.txt:hacking>=0.8.0,<0.9
> tuskar/test-requirements.txt:hacking>=0.9.2,<0.10
> zaqar/test-requirements-py3.txt:hacking>=0.8.0,<0.9
> zaqar/test-requirements.txt:hacking>=0.9.2,<0.10
>
> I won't fix them myself. Note that the new hacking version indroduces new
checks also might need to get fixed,
>

While I would like to see projects move off 0.9.x etc. I think the better
option is to backport the fix to 0.9.x and 0.8.x as needed.

> Andreas
>
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
>   SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>    GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton,
>        HRB 21284 (AG Nürnberg)
>     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150519/6e289d70/attachment.html>


More information about the OpenStack-dev mailing list