Open Stack

Someone from my team had installed the OS on baremetal with a wrong 'date'
When this node was added to the Openstack controller, the logs from the
neutron-agent on the compute node showed - "AMQP connected". But the neutron
agent-list command would not list this agent at all.

I could figure out the problem when the neutron-server debug logs were 
enabled
and it vaguely pointed at the rejection of AMQP connections due to a 
timestamp
miss match. The neutron-server was treating these requests as stale due 
to the
timestamp of the node being behind the neutron-server. However, there's no
good way to detect this if the agent runs on a node which is ahead of time.

I recently raised a bug here: 
https://bugs.launchpad.net/neutron/+bug/1432582

And tried to resolve this with the review:
https://review.openstack.org/#/c/165539/

It went through quite a few +2s after 15 odd patch sets but we still are not
in common ground w.r.t addressing this situation.

My fix tries to log better and throw up an exception to the neutron agent on
FIRST time boot of the agent for better detection of the problem.

I would like to get your thoughts on this fix. Whether this seems legit 
to have
the fix per the patch OR could you suggest a approach to tackle this OR 
suggest
just abandoning the change.