Open Stack

On 03/27/2015 07:21 AM, Sean Dague wrote:
> On 03/26/2015 06:46 PM, Robert Collins wrote:
>> On 27 March 2015 at 09:14, Ryan Brown <rybrown at redhat.com> 
>> wrote:
>> 
>>> Ooof, that's huge. If we can configure it to be less
>>> aggressive I love the *idea* of having everything formatted
>>> semantically, but that's a pretty major burden for everyone
>>> involved.
>> 
>> It's huge today. It wouldn't be if we did it :).
>> 
>> I suggest that given the other aspects of our code review
>> system, we might treat this like translations as a long term
>> thing - that is setup a job somewhere to run the autoformatter
>> against trunk and submit the result as a patchset.
>> 
>> To get over the initial hump, I'd have a human break the patch
>> up into per-file changes or some such.
>> 
>> A variation would be to have a config file saying which files are
>> covered, and slowly dial that up, one file at a time.
>> 
>> Once everything is covered, and we're dealing with commits that 
>> change things async (via the job above), then we can talk about 
>> how to help developers submit code using it in the first place.
> 
> Honestly, is there a problem here that really needs to be solved? 
> I've been a little confused about this thread because I thought 
> we're all actively calling people out for nit picking irrelevant 
> style issues.
> 
> I feel like building a large system to avoid not being human to 
> each other as completely dysfunctional.
> 
> In the Nova tree we have many cross cutting efforts that need to 
> touch a lot of things (v3 renames, mox -> mock). This seems like 
> giant churn for no real gain.
> 
> I'm not convinced the answer to white space fights is a tool. I 
> think it's stop being silly, actively call out cores when they
> are, and actively call out new folks that it is completely
> unhelpful in the reviewing (and only going to raise ire of core
> teams, not ingratiate yourself).

++