[openstack-dev] [oslo] oslo.concurrency runtime dependency on fixtures/testtools

Robert Collins robertc at robertcollins.net
Thu Mar 12 19:42:18 UTC 2015


On 13 March 2015 at 05:06, Ben Nemec <openstack at nemebean.com> wrote:
> On 03/12/2015 09:18 AM, Brant Knudson wrote:
>> On Thu, Mar 12, 2015 at 7:20 AM, Davanum Srinivas <davanum at gmail.com> wrote:
>>
>>> Alan,
>>>
>>> We are debating this on:
>>> https://review.openstack.org/#/c/157135/
>>>
>>> Please hop on :)
>>> -- dims
>>>
>>> On Thu, Mar 12, 2015 at 5:28 AM, Alan Pevec <apevec at gmail.com> wrote:
>>>> Hi,
>>>>
>>>> hijacking this thread to point out something that feels wrong in the
>>>> dependency chain which jumped out:
>>>>
>>>>> Colecting testtools>=0.9.22 (from
>>> fixtures>=0.3.14->oslo.concurrency>=1.4.1->keystone==2015.1.dev395)
>>>>
>>>> fixtures is imported in oslo_concurrency/fixture/lockutils.py but
>>>> that's not really used at _runtime_
>>>>
>>>>
>>>> Cheers,
>>>> Alan
>>>>
>>>
>>
>> And it's also being discussed in keystone for deps for non-default
>> features: https://review.openstack.org/#/c/162360/
>>
>> -- Brant
>
> We actually have a spec open to discuss this for the Oslo libs.  Would
> love to get more input on it: https://review.openstack.org/#/c/153966/
>
> It's possible that will need to become a cross-project spec if we
> determine that more projects need an optional deps policy (which is
> sounding like the case).

Nit picking just a little, I think this is by definition
cross-project: pbr affects every project, and all the proposals around
this casually propose modifying pbr :). That said I've commented on
both reviews.

tl;dr I'm proposing:
 - a single new file extras.txt
 - ini sections one per extras
 - glue in pbr to make this automatic

-Rob

-- 
Robert Collins <rbtcollins at hp.com>
Distinguished Technologist
HP Converged Cloud



More information about the OpenStack-dev mailing list