[openstack-dev] [Fuel] Recent issues with our review workflow

Ryan Moe rmoe at mirantis.com
Tue Mar 10 23:36:12 UTC 2015

Here are some examples of proposing changes prior to being merged in master
[0][1][2][3][4]. [0] is a perfect example of why this isn't a good process.
A change was proposed to stable/6.0 before master was merged, and now the
change to master needs to be reworked based on review feedback. Premature
backporting just creates unnecessary additional work. I'd also like to give
a friendly reminder to make sure we maintain the Change-Id and author of
any change we backport.

The wiki [5] has also been updated to make this explicit.



On Tue, Mar 10, 2015 at 4:20 AM, Tomasz Napierala <tnapierala at mirantis.com>

> > On 09 Mar 2015, at 18:21, Ryan Moe <rmoe at mirantis.com> wrote:
> >
> > Hi All,
> >
> > I've noticed a few times recently where reviews have been abandoned by
> people who were not the original authors. These reviews were only days old
> and there was no prior notice or discussion. This is both rude and
> discouraging to contributors. Reasons for abandoning should be discussed on
> the review and/or in email before any action is taken.
> Hi Ryan,
> I was trying to find any examples, and the only one I see is:
> https://review.openstack.org/#/c/152674/
> I spoke to Bogdan and he agreed it was not proper way to do it, but they
> were in a rush - I know, it does not explain anything really.
> Do you have any other examples? I’d like to clarify them
> Regards,
> --
> Tomasz 'Zen' Napierala
> Sr. OpenStack Engineer
> tnapierala at mirantis.com
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150310/dca6c3cc/attachment.html>

More information about the OpenStack-dev mailing list