[openstack-dev] [Nova] pci stats format and functional tests
yunhong.jiang at intel.com
Thu Mar 5 22:16:34 UTC 2015
Paul, you are right that the 'extra_info' should not be in the os-pci:pci_stats, since it's not part of 'pool-keys' anymore, but I'm not sure if both 'key1' and 'phys_function' will be part of the pci_stats.
From: Murray, Paul (HP Cloud) [mailto:pmurray at hp.com]
Sent: Thursday, March 5, 2015 11:39 AM
To: openstack-dev at lists.openstack.org
Subject: [openstack-dev] [Nova] pci stats format and functional tests
I know Yunhong Jiang and Daniel Berrange have been involved in the following, but I thought it worth sending to the list for visibility.
While writing code to convert the resource tracker to use the ComputeNode object realized that the api samples used in the functional tests are not the same as the format as the PciDevicePool object. For example: hypervisor-pci-detail-resp.json has something like this:
"phys_function": "[[\"0x0000\", \"0x04\", \"0x00\", \"0x1\"]]"
My understanding from interactions with yjiang5 in the past leads me to think that something like this is what is actually expected:
"phys_function": "[[\"0x0000\", \"0x04\", \"0x00\", \"0x1\"]]",
This is the way the PciDevicePool object expects the data structure to be and is also the way the libvirt virt driver creates pci device information (i.e. without the "extra_info" key). Other than that (which is actually pretty clear) I couldn't find anything to tell me definitively if my interpretation is correct and I don't want to change the functional tests without being sure they are wrong. So if anyone can give some guidance here I would appreciate it.
I separated this stuff out into a patch with a couple of other minor cleanups in preparation for the ComputeNode change, see: https://review.openstack.org/#/c/161843
Let me know if I am on the right track,
Nova Technical Lead, HP Cloud
+44 117 316 2527
Hewlett-Packard Limited registered Office: Cain Road, Bracknell, Berks RG12 1HN Registered No: 690597 England. The contents of this message and any attachments to it are confidential and may be legally privileged. If you have received this message in error, you should delete it from your system immediately and advise the sender. To any recipient of this message within HP, unless otherwise stated you should consider this message and attachments as "HP CONFIDENTIAL".
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev