Open Stack

Thomas,

Is anyone willing to the work needed to get the existing Nova vmware
driver scenarios with any alternate python library acceptable to
Debian? If not, this discussion is moot.

-- dims

On Mon, Jun 15, 2015 at 9:16 AM, Thomas Goirand <zigo at debian.org> wrote:
> On 06/15/2015 11:31 AM, Joe Gordon wrote:
>> Nova itself doesn't depend on suds anymore.
>
> A quick grep still shows references to suds (that's in Kilo, but the
> master branch shows similar results):
>
> etc/nova/logging_sample.conf:qualname = suds
>
> nova/tests/unit/test_hacking.py:            " def
> fake_suds_context(calls={}):"))))
>
> nova/tests/unit/virt/vmwareapi/test_vim_util.py:        with
> stubs.fake_suds_context(calls):
>
> nova/tests/unit/virt/vmwareapi/stubs.py:def fake_suds_context(calls=None):
>
> nova/tests/unit/virt/vmwareapi/stubs.py:    """Generate a suds client
> which automatically mocks all SOAP method calls.
>
> nova/tests/unit/virt/vmwareapi/stubs.py:
> mock.patch('suds.client.Client', fake_client),
>
> nova/tests/unit/virt/vmwareapi/test_driver_api.py:import suds
>
> nova/tests/unit/virt/vmwareapi/test_driver_api.py:
> mock.patch.object(suds.client.Client,
>
> nova/tests/unit/virt/vmwareapi/fake.py:    """Fake factory class for the
> suds client."""
>
> nova/tests/unit/virt/vmwareapi/fake.py:        """Initializes the suds
> client object, sets the service content
>
> nova/virt/vmwareapi/vim_util.py:import suds
>
> nova/virt/vmwareapi/vim_util.py:    for k, v in
> suds.sudsobject.asdict(obj).iteritems():
>
> nova/config.py:                       'qpid=WARN', 'sqlalchemy=WARN',
> 'suds=INFO',
>
> test-requirements.txt:suds>=0.4
>
>
>> Oslo.vmware has a suds
>> dependency, but that is only needed if you are using the vmware virt
>> driver in nova.
>
> It's used in unit tests, no?
>
>> So nova's vmware driver depends on suds (it may be suds-jurko these
>> days)
>
> As I wrote, suds-jurko isn't acceptable either, as it's also not
> maintained upstream.
>
>> but not nova in general.
>
> If we don't want suds, we don't want suds. Not just "it's only in some
> parts" kind of answer. Especially, it should appear in
> tests-requirements.txt and in vmwareapi unit tests. Don't you think?
>
> Cheers,
>
> Thomas Goirand (zigo)
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Davanum Srinivas :: https://twitter.com/dims