[openstack-dev] [nova] nova unittests will be affected by mock 1.3

Sean Dague sean at dague.net
Thu Jul 23 23:54:42 UTC 2015

On 07/23/2015 06:34 PM, Robert Collins wrote:
> I've released mock 1.3 which really correctly fixes the behaviour of
> mock_open. Unfortunately there is a test in nova that is faulty (and
> was faulty but silently so with 1.2).
>  https://review.openstack.org/204222 fixes this up.
> I had intended to let it land before releasing, but I forgot I had it
> applied to my local tree when I ran the nova tests with mock 1.3.0
> before releasing.
> So the good news is, I know that patch fixes things.
> The bad news is, I know its needed.
> Sorry :(.
> jroll verified that Ironic works with mock 1.3, so thats known good.
> BTW - the reason for doing it now, is that I'm travelling in 24 hours,
> and releasing it closer to then would be bad, and the Python 3.5
> release is happening, and it needs to sync reasonably closely with
> that. Rock and hard place.

I just fast approved the patch given the circumstances (and the fact
that much of Nova core is either on a plane or drinking right now). It's
a small tweak on our unit tests, and hopefully frees you up to do the

Thanks for the heads up on checking the Nova tests before the release,
and providing the fix to the unit tests.


Sean Dague

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 465 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150723/8ccfc0cf/attachment.pgp>

More information about the OpenStack-dev mailing list