[openstack-dev] [Ironic] What to do with reservation check in node update API?

Lucas Alvares Gomes lucasagomes at gmail.com
Tue Jul 21 13:26:35 UTC 2015


Hi,

> So, it looks like the only reason we check the reservation field here is
> because we want to return a 409 for "node is locked" rather than a 400,
> right? do_node_deploy and such will raise a NodeLocked, which should do
> the same as this check. It's unclear to me why we can't just remove this
> check and let the conductor deal with it.
>

Looking at the code this assumption seems to be correct. If the RPC
methods raise NodeLocked we will return 409 as expected.

Cheers,
Lucas



More information about the OpenStack-dev mailing list