Open Stack

I'm with Stanislaw on this one: abandoning reviews just to make numbers
*look* better will accomplish nothing.

The only benefit I can see is cleaning up reviews that we *know* don't need
to be considered, so that it's easier for reviewers to find the reviews
that still need attention. I don't see this as that much of a problem,
finding stuff to review in Fuel Review Inbox [0] is not hard at all.

[0] https://wiki.openstack.org/wiki/Fuel#Development_related_links

And the state of our review backlog is such that it's not safe to
auto-abandon reviews without looking at them, and if a contributor has
spent time looking at a review, abandoning it manually is one click away.

If we do go with setting up an auto-abandon rule, it should be extremely
conservative, for example: CR has a negative vote from a core reviewer AND
there were no comments or positive votes from anyone after that AND it has
not been touched in any way for 2 months.

On Wed, Jul 15, 2015 at 5:10 PM Mike Scherbakov <mscherbakov at mirantis.com>
wrote:

> Folks,
> let's execute here. Numbers are still large. Did we have a chance to look
> over the whole queue?
>
> Can we go ahead and abandon changes having -1 or -2 from reviewers for
> over than a months or so?
> I'm all for just following standard OpenStack process [1], and then change
> it only if there is good reason for it.
>
> [1] https://wiki.openstack.org/wiki/Puppet#Patch_abandonment_policy
>
>
> On Thu, Jul 9, 2015 at 6:27 PM Stanislaw Bogatkin <sbogatkin at mirantis.com>
> wrote:
>
>> 2 weeks seems too small for me. We easy can be in situation when fix for
>> medium bug is done, but SCF starts. And gap between SCF and release easily
>> can be more than a month. So, 2 months seems okay for me if speaking about
>> forcibly applying auto-abandon by major vote. And I'm personally against
>> such innovation at all.
>>
>> On Thu, Jul 9, 2015 at 5:37 PM, Davanum Srinivas <davanum at gmail.com>
>> wrote:
>>
>>> That's a very good plan ("Initial feedback/triage") Mike.
>>>
>>> thanks,
>>> dims
>>>
>>> On Thu, Jul 9, 2015 at 3:23 PM, Mike Scherbakov
>>> <mscherbakov at mirantis.com> wrote:
>>> > +1 for just reusing existing script, and adjust it on the way. No need
>>> to
>>> > immediately switch from infinite time to a couple of weeks, we can
>>> always
>>> > adjust it later. But 1-2 month should be a good start already.
>>> >
>>> > Our current stats [1] look just terrible. Before we enable an
>>> auto-abandon,
>>> > we need to go every single patch first, and review it / provide
>>> comment to
>>> > authors. The idea is not to abandon some good patches, and not to
>>> offend
>>> > contributors...
>>> >
>>> > Let's think how we can approach it. Should we have core reviewers to
>>> check
>>> > their corresponding components?
>>> >
>>> > [1] http://stackalytics.com/report/reviews/fuel-group/open
>>> >
>>> > On Wed, Jul 8, 2015 at 1:13 PM Sean M. Collins <sean at coreitpro.com>
>>> wrote:
>>> >>
>>> >> Let's keep it at >4 weeks without comment, and Jenkins failed -
>>> similar
>>> >> to the script that Kyle Mestery uses for Neutron. In fact, we could
>>> >> actually just use his script ;)
>>> >>
>>> >>
>>> >>
>>> https://github.com/openstack/neutron/blob/master/tools/abandon_old_reviews.sh
>>> >> --
>>> >> Sean M. Collins
>>> >>
>>> >>
>>> __________________________________________________________________________
>>> >> OpenStack Development Mailing List (not for usage questions)
>>> >> Unsubscribe:
>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>> >
>>> > --
>>> > Mike Scherbakov
>>> > #mihgen
>>> >
>>> >
>>> __________________________________________________________________________
>>> > OpenStack Development Mailing List (not for usage questions)
>>> > Unsubscribe:
>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>> >
>>>
>>>
>>>
>>> --
>>> Davanum Srinivas :: https://twitter.com/dims
>>>
>>>
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
> --
> Mike Scherbakov
> #mihgen
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150717/c22deb3c/attachment.html>