[openstack-dev] [Murano] SQLite support - drop or not?
rkamaldinov at mirantis.com
Mon Jan 26 15:05:14 UTC 2015
On Mon, Jan 26, 2015 at 3:03 PM, Andrew Pashkin <apashkin at mirantis.com> wrote:
> On 23.01.2015 23:39, Ruslan Kamaldinov wrote:
> 1. Use ModelsMigrationsSync from  in tests to make sure that SQLAlchemy
> models are in sync with migrations. Usage example can be found at 
> Seems like it is a great helper, as I understand it runs all migrations and
> then compares DB state with models state and throws an error if they are out
> of sync.
> What I don't understand - why they still manually write checks for every
> migration ? This is redundant, because ModelsMigrationsSync already does
> the job testing that DB is in sync with models.
> By the way in Heat project they do the same thing . What am I missing?
I think it's still important to perform migration specific checks. We
want to make sure that DB is in expected state after each specific
> 2. Populate DB schema from SQLAlchemy models in unit-tests which require
> access to DB
> You mean - using these tools ?
Yes, this one. We still have this code in source tree:
> In what conditions 5) will fail? I see only these cases:
> - If data migrations would be introduced and Murano would require some data
> in DB to work correctly.
Actually, we already do that. We populate initial set of categories:
Would it affect anyone? I don't think so. You always can populate
these categories manually.
> - If Murano would use some database-specific features (stored procedures
That should never happen :)
> There are good chances that these cases will never happen in reality, as I
> understand, so I tend to agree.
More information about the OpenStack-dev