Thanks for that, Joe. I'd say the cons miss 'It looks ugly in places'. On 25 February 2015 at 20:54, Joe Gordon <joe.gordon0 at gmail.com> wrote: > > On Wed, Feb 25, 2015 at 10:51 AM, Duncan Thomas <duncan.thomas at gmail.com> > wrote: > >> Hi >> >> So a review [1] was recently submitted to cinder to fix up all of the >> H302 violations, and turn on the automated check for them. This is >> certainly a reasonable suggestion given the number of manual reviews that >> -1 for this issue, however I'm far from convinced it actually makes the >> code more readable, >> >> Is there anybody who'd like to step forward in defence of this rule and >> explain why it is an improvement? I don't discount for a moment the >> possibility I'm missing something, and welcome the education in that case >> >> > H302 originally comes from > http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Imports#Imports > > >> Thanks >> >> >> [1] https://review.openstack.org/#/c/145780/ >> -- >> Duncan Thomas >> >> __________________________________________________________________________ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: >> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> >> > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Duncan Thomas -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150225/4fc4823b/attachment.html>