[openstack-dev] What should openstack-specs review approval rules be ?

Doug Hellmann doug at doughellmann.com
Thu Feb 12 21:20:02 UTC 2015



On Wed, Jan 28, 2015, at 08:25 AM, Thierry Carrez wrote:
> Hi everyone,
> 
> When we first introduced the cross-project specs (specs for things that
> may potentially affect all OpenStack projects, or where more convergence
> is desirable), we defaulted to rather simple rules for approval:
> 
> - discuss the spec in a cross-project meeting
> - let everyone +1/-1 and seek consensus
> - wait for the affected PTLs to vote
> - wait even more
> - tally the votes (and agree a consensus is reached) during a TC meeting
> - give +2/Worflow+1 to all TC members to let them push the Go button
> 
> However, the recent approval of the Log guidelines
> (https://review.openstack.org/#/c/132552/) revealed that those may not
> be the rules we are looking for.
> 
> Sean suggested that only the TC chair should be able to workflow+1 to
> avoid accidental approval.
> 
> Doug suggested that we should use the TC voting rules (7 YES, or at
> least 5 YES and more YES than NO) on those.
> 
> In yesterday's meeting, Sean suggested that TC members should still have
> a -2-like veto (if there is no TC consensus on the fact that community
> consensus is reached, there probably is no real consensus).

In the past we've shown -1 votes to be a sign of a lack of consensus,
and I'm not aware of any cases where a close vote went through. In fact,
the only close vote I can remember since we started voting in gerrit was
the Zaqar graduation vote, and that outcome kept the status quo in the
face of no clear consensus.

Given that, I'm not sure we need a true veto but I could accept it if
that's the consensus.

> 
> There was little time to discuss this more in yesterday's TC meeting, so
> I took the action to push that discussion to the ML.
> 
> So what is it we actually want for that repository ? In a world where
> Gerrit can do anything, what would you like to have ?
> 
> Personally, I want our technical community in general, and our PTLs/CPLs
> in particular, to be able to record their opinion on the proposed
> cross-project spec. Then, if consensus is reached, the spec should be
> approved.
> 
> This /could/ be implemented in Gerrit by giving +1/-1 to everyone to
> express technical opinion and +2/-2 to TC members to evaluate consensus
> (with Workflow+1 to the TC chair to mark when all votes are collected
> and consensus is indeed reached).
> 
> Other personal opinions on how you'd like this repository reviews to be
> run ?
> 
> -- 
> Thierry Carrez (ttx)
> 
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list