[openstack-dev] [oslo.db] PyMySQL review

Julien Danjou julien at danjou.info
Mon Feb 2 08:49:30 UTC 2015


On Fri, Jan 30 2015, Yuriy Taraday wrote:

> That's a great research! Under its impression I've spent most of last
> evening reading PyMySQL sources. It looks like it not as much need C
> speedups currently as plain old Python optimizations. Protocol parsing code
> seems very inefficient (chained struct.unpack's interleaved with data
> copying and util method calls that do the same struct.unpack with
> unnecessary type check... wow...) That's a huge place for improvement.
> I think it worth spending time on coming vacation to fix these slowdowns.
> We'll see if they'll pay back those 10% slowdown people are talking about.

With all my respect, you may be right, but I need to say it'd be better
to profile and then optimize rather than spend time rewriting random
parts of the code then hoping it's going to be faster. :-)

-- 
Julien Danjou
// Free Software hacker
// http://julien.danjou.info
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 826 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150202/c67150b5/attachment.pgp>


More information about the OpenStack-dev mailing list