[openstack-dev] [OpenStack-Infra] Gerrit Upgrade to ver 2.11, completed.

Carl Baldwin carl at ecbaldwin.net
Tue Dec 22 21:52:03 UTC 2015


On Mon, Dec 21, 2015 at 6:21 PM, Zaro <zaro0508 at gmail.com> wrote:
> Hit '?' and it says '/' is find, give that a try.

'/' isn't really much better.  It seems to highlight all of the
occurrences but I can't find a way to navigate to the next/previous
occurence with the keyboard.  I see that the scroll bar shows a small
indication that there are many matches within the file and so I could
scroll to them if I want to move my fingers to the trackpad to scroll.

Also, it only searches for text in the file.  Today, I wanted to
search for comments from a particular author by searching for that
person's name on the page.  It only found the first two (of four)
because the others were down the page.

To me, this is a pretty annoying regression from 2.8.

> Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files
> is only available in unified diff view.  I don't remember if it was
> available in side-by-side view on Gerrit 2.8.

Yes, it was available in 2.8 in side-by-side view, I used it often.
It is unfortunate that it only works in unified diff view.  I tried
switching to unified diff view in a file.  It worked but then when I
used it to navigate to another file, it switched back to side-by-side
diff mode and the file list was sort of stuck to the page in an odd
way where the file list was visible but was behind the side-by-side
diff.  It made the whole page unreadable.  Essentially, I'll have to
switch my default to unified view for it to be useful.

Carl



More information about the OpenStack-dev mailing list