Open Stack

Hit '?' and it says '/' is find, give that a try.

Looks like in Gerrit 2.11 the 'f' to get a popup of the list of files
is only available in unified diff view.  I don't remember if it was
available in side-by-side view on Gerrit 2.8.

-Khai


On Mon, Dec 21, 2015 at 5:04 PM, Carl Baldwin <carl at ecbaldwin.net> wrote:
> I also really miss being able to pull up the list of files in diff
> view with the 'f' key.  Any equivalent?
>
> Carl
>
> On Mon, Dec 21, 2015 at 4:07 PM, Carl Baldwin <carl at ecbaldwin.net> wrote:
>> I noticed a couple of things today while reviewing a largish page [1].
>> First, when I search for something using the browser's builtin search
>> (Chrome, Mac OSX Yosemite), it doesn't seem to find occurrences that
>> are not in the visible portion of the page.  For example, when I
>> search for DNSDOMAIN, I get 1 hit from the top of the file.  The file
>> actually has almost 30 hits for this string.  For example, scroll down
>> to about L310 in the file.  You'll see them all over the place (and
>> now Chrome's search finds these hits if you try again).  I use to use
>> search within a file with the old gerrit and never noticed this
>> problem.
>>
>> The other thing that I found annoying is when I scroll the page with
>> my trackpad, it now jumps around sometimes to a different part of the
>> page.  For example, I'll scroll up to find a spot in the file and when
>> I think I've arrived, it will jump back down the file a bit.  It is
>> disorienting.  Of course, now it isn't doing it anymore so it doesn't
>> seem to be all the time.  It was behaving this way for a good 20
>> minutes trying to get through this file.
>>
>> Carl
>>
>> Carl
>>
>> [1] https://review.openstack.org/#/c/212213/36/neutron/db/dns_db.py
>>
>> On Thu, Dec 17, 2015 at 8:17 PM, Brian Haley <brian.haley at hpe.com> wrote:
>>> On 2015-12-16 16:24, openstack-dev-request at lists.openstack.org wrote:
>>>>
>>>> Thanks to everyone for their patience while we upgraded to Gerrit
>>>> 2.11.  I'm happy to announce that we were able to successfully
>>>> completed this task at around 21:00 UTC.  You may hack away once more.
>>>>
>>>> If you encounter any problems, please let us know here or in
>>>> #openstack-infra on Freenode.
>>>
>>>
>>> I'm still undecided on 2.11, have to give it more time, but I have noticed
>>> one thing that's annoying...
>>>
>>> Trying to copy text from a review no longer works easily.  When I highlight
>>> text there's a little "bubble" pop-up of {press c to comment}, which seems
>>> to interfere with both my three-button mouse copy buffer, as well as Ctrl-C.
>>> Call me a nitpicker, but having to highlight text, right-button click, Copy,
>>> right-button click, Paste, is a pain.
>>>
>>> Maybe someone has a simple work-around for that.
>>>
>>> -Brian
>>>
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev