[openstack-dev] [Murano] Documentation on how to Start Contributing

Victor Ryzhenkin vryzhenkin at mirantis.com
Thu Aug 27 01:14:51 UTC 2015


Hey! 

the code does not seem to be inside the murano git repository, but under python-muranoclient.
The code of murano-api located here [1]. The client is just a client for using murano api functions from python ;)

But I don't see python-muranoclient files under my deployed devstack
True. This happened because python-muranoclient was installed from PyPi. In this case You will find this directory in dist-packages in python dir.

So, I have a two suggestions for You. 

The first: To install non-released client with devstack you need to add into your local.conf/localrc the variable ‘LIBS_FROM_GIT=python-muranoclient’. After deploying devstack you will see the python-muranoclient dir and in system will installed the latest client from master. You can use MURANO_PYTHONCLIENT_REPO=/home/… to try to install client with devstack from your local repository(as you did for murano in last tries).

The second: But I recommend you to use python-virtualenv for client tests. Install venv, activate venv, and install changed client via pip install -e ${changed_client_dir}.

I hope, this help you ;)

Best regards!

[1] https://github.com/openstack/murano/tree/master/murano/api

-- 
Victor Ryzhenkin
Junior QA Engeneer
freerunner on #freenode

Включено 27 августа 2015 г. в 3:56:56, Vahid S Hashemian (vahidhashemian at us.ibm.com) написал:

Hi Victor,

Thanks for pointing out the issue with earlier deployment. Since I took your advice I don't run into that problem again.
And thanks for the pointer on how to restart murano daemons. I think I understand how to change murano code and test my changes locally.

I have one more question: if I want to make changes to murano-api code, the code does not seem to be inside the murano git repository, but under python-muranoclient.
But I don't see python-muranoclient files under my deployed devstack so I can modify and restart services. An example, would be python-muranoclient/muranoclient/v1/shell.py which does not seem to exist under /opt/stack.
Am I on the right track? If so, how do I test changes I want to make to the api code?

Thank you.

Regards,
-----------------------------------------------------------------------------
Vahid Hashemian, Ph.D.
Advisory Software Engineer, IBM Cloud Labs		





From:        Victor Ryzhenkin <vryzhenkin at mirantis.com>
To:        Vahid S Hashemian/Silicon Valley/IBM at IBMUS
Cc:        "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
Date:        08/26/2015 05:28 PM
Subject:        Re: [openstack-dev] [Murano] Documentation on how to Start Contributing



Wow!

And changed the plugin.sh file back to original. However, with a cleaned devstack (./unstack.sh, ./clean.sh, and removed /opt/stack) I still got the error I mentioned in my previous post. Full stack log is attached.

Looks like I’ve found this tricky one ;)

In your log:
2015-08-26 21:02:18.010 | + source /home/stack/devstack/extras.d/70-murano.sh stack post-config
2015-08-26 21:02:18.010 | ++ is_service_enabled murano
2015-08-26 21:02:18.012 | ++ return 0

And this one:
2015-08-26 21:02:41.481 | + [[ -f /opt/stack/murano/devstack/plugin.sh ]]
2015-08-26 21:02:41.481 | + source /opt/stack/murano/devstack/plugin.sh stack post-config

Murano tried to deploy multiple times. I think this happened because you using plugin and libs together. Need try to remove murano libs and extras from devstack directory(lib/murano; lib/murano-dashboard; extras.d/70-murano.sh) or turn off the plugin. We need to use one method in one time.

As per your suggestion I was going to test your first suggestion, but I was unable to find any murano service running on my server after the completion of ./stack.sh (which I tested installed murano with it).
The command "sudo service murano status" returns "murano: unrecognized service".
Am I missing something?
In devstack services starts not as daemons, but in screen. To get this processes view, you need to cd into your devstack dir and launch ./rejoin-stack.sh.

To restart murano, need to move into murano-api and murano-engine screens, press CTRL-C, and using up arrow launch service, which was stopped.



--
Victor Ryzhenkin
Junior QA Engeneer
freerunner on #freenode

Включено 27 августа 2015 г. в 2:38:11, Vahid S Hashemian (vahidhashemian at us.ibm.com) написал:

Hi Victor,

Thank you very much for your detailed response. It was very helpful.

I tried the approach you suggested, and modified the local.conf file by adding these lines:

MURANO_REPO=/home/stack/workspace/murano
enable_plugin murano https://github.com/openstack/murano

And changed the plugin.sh file back to original. However, with a cleaned devstack (./unstack.sh, ./clean.sh, and removed /opt/stack) I still got the error I mentioned in my previous post. Full stack log is attached.



As per your suggestion I was going to test your first suggestion, but I was unable to find any murano service running on my server after the completion of ./stack.sh (which I tested installed murano with it).
The command "sudo service murano status" returns "murano: unrecognized service".
Am I missing something?

Thanks again for your assistance.

Regards,
-----------------------------------------------------------------------------

Vahid Hashemian, Ph.D.
Advisory Software Engineer, IBM Cloud Labs
Email: vahidhashemian at us.ibm.com
Phone: 1-408-463-2380		

IBM Silicon Valley Lab
555 Bailey Ave.
San Jose, CA 95141






From:        Victor Ryzhenkin <vryzhenkin at mirantis.com>
To:        Vahid S Hashemian/Silicon Valley/IBM at IBMUS, "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
Date:        08/25/2015 05:47 PM
Subject:        Re: [openstack-dev] [Murano] Documentation on how to Start Contributing



Hi, Vahid!


- Modified /home/stack/workspace/murano/devstack/plugin.sh based on Gosha's suggestion and replacedMURANO_REPO=${MURANO_REPO:-${GIT_BASE}/openstack/murano.git}withMURANO_REPO=/home/stack/workspace/murano.

Unfortunately, I’m not sure, that using local path as MURANO_REPO will work. At least, because I never heard about use cases like this.
But looks like you are given it a try. So, I suggest you to make sure, that you executed ./unstack and ./clean.sh scripts, before start deployment. If you using clean host, this one not needed.
Also, I think that is not needed to change plugin’s code. You can define MURANO_REPO=/home/stack/… in your localrc/local.conf file and use
"enable_plugin murano https://github.com/openstack/murano»

What about suggestions, how to test your local changes.
I see a two easy ways to do it without using local repositories.
1. Deploy devstack with murano from master as is using plugin or libs and replace old files in /opt/stack/murano with new ones, that you changed. After this need to restart murano services.
2. Upload your changes to gerrit, and use as MURANO_REPO=https://review.openstack.org/openstack/muranoand MURANO_BRANCH=<refs/changes/…/.../…>.

Both of methods are good.

But this errors on me when I run ./stack.sh:
      ERROR: openstack Conflict occurred attempting to store user - Duplicate Entry (HTTP 409) (Request-ID: req-805b487c-44fe-4155-8349-65362c2a34ee)
It will be really good, if you can give more information (I mean full, or last part of deployment log)

Best Regards!
--
Victor Ryzhenkin
Junior QA Engeneer
freerunner on #freenode

Включено 26 августа 2015 г. в 2:49:46, Vahid S Hashemian (vahidhashemian at us.ibm.com) написал:

OK. So I'm still having some issues with this.

Here's what I have done:

- Followed instructions on http://murano.readthedocs.org/en/latest/install/development.htmlup to step 4
      * cloned murano into /home/stack/workspace/murano
      * cloned devstack into /home/stack/devstack

- Modified /home/stack/workspace/murano/devstack/plugin.sh based on Gosha's suggestion and replaced MURANO_REPO=${MURANO_REPO:-${GIT_BASE}/openstack/murano.git}withMURANO_REPO=/home/stack/workspace/murano.

- Modified /home/stack/devstack/local.conf and addedenable_plugin murano /home/stack/workspace/murano

But this errors on me when I run ./stack.sh:
      ERROR: openstack Conflict occurred attempting to store user - Duplicate Entry (HTTP 409) (Request-ID: req-805b487c-44fe-4155-8349-65362c2a34ee)

I appreciate some clarification. Thanks.

Regards,
-----------------------------------------------------------------------------

Vahid Hashemian, Ph.D.
Advisory Software Engineer, IBM Cloud Labs		







From:        Vahid S Hashemian/Silicon Valley/IBM at IBMUS
To:        "OpenStack Development Mailing List \(not for usage questions\)" <openstack-dev at lists.openstack.org>
Date:        07/10/2015 04:02 PM
Subject:        Re: [openstack-dev] [Murano] Documentation on how to        Start        Contributing



Thanks Nikolay and Gosha.

As Gosha mentioned I'd like to be able to integrate my local changes to Murano into my devstack installation.
I figured for UI changes I can probably make the changes directly to the file and restart my apache2 service.
However, I am looking for an easy way to test back-end changes, like if I had to modify how a particular CLI behaves, and test it in my devstack environment.

Gosha, thanks for the info you sent. Can you clarify something though?

In local.conf there is a line "enable_plugin muranohttps://github.com/openstack/murano" pointing to the Murano's github repository.
In plugin.sh, on the other hand, there is a line "MURANO_REPO=${MURANO_REPO:-${GIT_BASE}/openstack/murano.git}" that also another configuration for Murano repository.
Are these two related? Should I modify both for the purpose I mentioned above?  
Also, I cannot find a "murano.git" file on my server (as referenced in line 17 of plugin.sh). Should I use something like "/home/stack/murano/.git" instead?  

Thank you again for your help.  

Regards,
-----------------------------------------------------------------------------
Vahid Hashemian, Ph.D.
Advisory Software Engineer, IBM Cloud Labs		








From:        Georgy Okrokvertskhov <gokrokvertskhov at mirantis.com>
To:        "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
Date:        07/10/2015 07:45 AM  
Subject:        Re: [openstack-dev] [Murano] Documentation on how to Start        Contributing  



Hi,

If I understand correctly, you want to be able to install modified Murano from your own repository. There is a devstack integration script in Murano repository which does this. Here are lines where you can point to specific repository for Murano installation in devstack:https://github.com/openstack/murano/blob/master/devstack/plugin.sh#L17-L18

Installation procedure in the README.rst file in the folder devstack of murano repository.

Thanks
Gosha

On Thu, Jul 9, 2015 at 9:54 PM, Nikolay Starodubtsev <nstarodubtsev at mirantis.com> wrote:
Hi,
Can you describe what problems do you have with "bring code changes into a live Devstack environment, and test them".
If you want a real-time Q&A experience you can ask your questions at #murano on freenode.

                             
Nikolay Starodubtsev  
Software Engineer  
Mirantis Inc.  

Skype: dark_harlequine1

2015-07-10 2:32 GMT+03:00 Vahid S Hashemian <vahidhashemian at us.ibm.com>:
Hello,  

I am wondering if there is any documentation for new contributors that explains how to get up-to-speed with Murano development; something that covers how to bring code changes into a live Devstack environment, and test them.  
I've looked at the Murano documentation online and have not been able to find it.  

Any pointer is very much appreciated.

Thanks.  
-----------------------------------------------------------------------------

Vahid Hashemian, Ph.D.
Advisory Software Engineer, IBM Cloud Labs		



__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




--  
Georgy Okrokvertskhov
Architect,
OpenStack Platform Products,
Mirantis
http://www.mirantis.com
Tel. +1 650 963 9828
Mob. +1 650 996 3284__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150827/f6bffad3/attachment.html>


More information about the OpenStack-dev mailing list