Open Stack

Hi,

Changes in JS will be required anyway. Because currently it sends the data
in cluster attributes dictionary. So it should send the data to some
specific url.

Regarding to authentication we had similar problem with diagnostic snapshot
[1],
you still can perform authentication in Nailgun and then Nginx will
continue to
perform the action.

You can get cluster's ID from nginx, it will be something like:

    location ~ ^/api/clusters/(?<cluster_id>[0-9]+)/upload_key {
        upload_store /var/lib/fuel/ssl_keys/$cluster_id
        ....
    }

Thanks,

[1]
https://github.com/stackforge/fuel-specs/blob/5409aaca363dccf8e7598fc7995ce8ade1e68ebc/specs/7.0/snapshot-download-with-auth.rst#proposed-change

On Mon, Aug 24, 2015 at 3:31 PM, Stanislaw Bogatkin <sbogatkin at mirantis.com>
wrote:

> I preparing patches for library, but there was raised another question:
> how should we saving keypairs from UI? I see there two options:
>
> 1. It will be done via UI (JS?) that will post file to special URL and
> then it will be saved via nginx HttpUploadModule. Caveats here:
> - I don't know how we will deal with authentication. How nginx should
> understand that this file got from trusted source?
> - As we should place keys in different places for different clusters, some
> handler should so it, we cannot save files with pure nginx. Who will write
> this handler and maintain it?
>
> 2. It will be done via Nailgun that will store files directly in FS.
> Caveats here:
> - How about speed/locks? Now we store just small files with certificates
> (<4 kb in most of cases), but in future we, maybe, will need to save big
> files. Will a solution with Nailgun work okay?
> - Logs. As I understand, if file will be saved by nailgun API, it will be
> saved in logs and we need some tool to cut it out from there.
>
> So, which way seems better for you, folks?
>
> On Fri, Aug 21, 2015 at 1:59 PM, Adam Heczko <aheczko at mirantis.com> wrote:
>
>> Sorry in understood incorrectly - using HTTP/Web IMO usually makes kind
>> of overhead if designed from the beginning.
>> If there are some HTTP authentication/CSR request/key management
>> mechanisms already in place, of course there is no overhead.
>>
>> Regards,
>>
>> A.
>>
>> On Fri, Aug 21, 2015 at 12:43 PM, Evgeniy L <eli at mirantis.com> wrote:
>>
>>> Hi Adam,
>>>
>>> I'm not sure if understand you correctly, what do you mean by "overhead
>>> for
>>> certificate provisioning"? We already have all the mechanisms in place
>>> in order
>>> to provision certificates, the point is currently with user's
>>> certificates we work in
>>> absolutely different way and store them in absolutely different place.
>>> And this
>>> way leads to huge problems.
>>>
>>> Thanks,
>>>
>>> On Fri, Aug 21, 2015 at 1:33 PM, Adam Heczko <aheczko at mirantis.com>
>>> wrote:
>>>
>>>> Hi Evgeniy,
>>>> what you've proposed is all right, although it adds some overhead for
>>>> certificate provisioning.
>>>> In fact, to do it right we should probably define REST API for
>>>> provisioning certificates.
>>>> I'm rather for simplified approach, consisting of Shell / Puppet
>>>> scripts for certificate upload/management.
>>>>
>>>> Regards,
>>>>
>>>> A.
>>>>
>>>>
>>>> On Fri, Aug 21, 2015 at 12:20 PM, Evgeniy L <eli at mirantis.com> wrote:
>>>>
>>>>> Hi Stanislaw,
>>>>>
>>>>> I agree that user's certificates mustn't be saved in Nailgun database,
>>>>> in cluster attributes,
>>>>> in this case it can be seen in all the logs, which is terrible
>>>>> security problem,
>>>>> and we already have a place where we keep auto-generated certificates
>>>>> and
>>>>> ssh-keys, and those are copied to specific nodes by Astute.
>>>>>
>>>>> So UI should send the file to specific URL, Nginx should be configured
>>>>> to send auth
>>>>> request to backend, after request is authorised, Nginx should save the
>>>>> file into predefined
>>>>> directory, the same which we use for autogenerated certificates, in
>>>>> this case such
>>>>> tool as OSTF can take certificates from a single place.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> On Fri, Aug 21, 2015 at 12:10 PM, Stanislaw Bogatkin <
>>>>> sbogatkin at mirantis.com> wrote:
>>>>>
>>>>>> Hi folks.
>>>>>>
>>>>>> Today I want to discuss the way we save SSL keys for Fuel
>>>>>> environments. As you maybe know we have 2 ways to get a key:
>>>>>> a. Generate it by Fuel (self-signed certificate will be created in
>>>>>> this case). In this case we will generate private key, csr and crt in a
>>>>>> pre-deployment hook on master node and then copy keypair to the nodes which
>>>>>> needed it.
>>>>>>
>>>>>> b. Get a pre-generated keypair from user. In this case user should
>>>>>> create keypair by himself and then upload it through Fuel UI settings tab.
>>>>>> In this case keypair will be saved in nailgun database and then will
>>>>>> serialized into astute.yaml on cluster nodes, pulled from it by puppet and
>>>>>> saved into a file.
>>>>>>
>>>>>> Second way has some flaws:
>>>>>> 1. We already have some keys for nodes and we store them on master
>>>>>> node. Store keys in different places is bad, cause:
>>>>>> 1.1. User experience - user should remember that in some cases keys
>>>>>> will be store in FS and in some other cases - in DB.
>>>>>> 1.2. It brings problems for implementation in other different places
>>>>>> - for example, we need to get certificate for properly run OSTF tests and
>>>>>> now we should implement two different ways to deliver that certificate to
>>>>>> OSTF container. The same for fuel-cli - we should somehow get certificate
>>>>>> from DB and place it in FS to use it.
>>>>>> 2. astute.yaml is similar for all nodes. Not all of nodes needs to
>>>>>> have private key, but now we cannot control this.
>>>>>> 3. If keypair data serializes into astute.yaml it means than that
>>>>>> data automatically will be fetched when diagnostic snapshot will created.
>>>>>> So in some cases in can lead to security vulnerability, or we will must to
>>>>>> write another crutch to cut it out of diagnostic snapshot.
>>>>>>
>>>>>>
>>>>>> So I propose to get rid of saving keypair in nailgun database and
>>>>>> implement a way to always saving it to local FS on master node. We need to
>>>>>> implement next items:
>>>>>>
>>>>>> - Change UI logic that saving keypair into DB to logic that will save
>>>>>> it to local FS
>>>>>> - Implement according fixes in fuel-library
>>>>>>
>>>>>>
>>>>>> __________________________________________________________________________
>>>>>> OpenStack Development Mailing List (not for usage questions)
>>>>>> Unsubscribe:
>>>>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> __________________________________________________________________________
>>>>> OpenStack Development Mailing List (not for usage questions)
>>>>> Unsubscribe:
>>>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Adam Heczko
>>>> Security Engineer @ Mirantis Inc.
>>>>
>>>>
>>>> __________________________________________________________________________
>>>> OpenStack Development Mailing List (not for usage questions)
>>>> Unsubscribe:
>>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>
>>>>
>>>
>>>
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>>
>>
>>
>> --
>> Adam Heczko
>> Security Engineer @ Mirantis Inc.
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150824/d9ba37ad/attachment.html>