Open Stack

Hey,

So I can add support to turbo-hipster to apply migrate_flavor_data when 
it hits your migration (in fact I started to do this). This means the 
tests will pass on your change and continue to once it merges. I'll 
update the datasets after the next release but it'll probably be to a 
version before migrate_flavor_data is required so we'll actually still 
be able to test that functionality against real datasets.

The migrate_flavor_data command didn't actually work on the CLI (unless 
I'm missing something or did something odd). See 
https://review.openstack.org/#/c/175890/ where I fix the requirement of 
max_number. This likely means that operators have not bothered to do or 
test the migrate_flavor_data yet which could be a concern.

That said, I'm surprised migrate_flavor_data isn't just done as a 
migration. I'm guessing there is a reason it's a separate tool and that 
it has been discussed before, but if we are going to have a migration 
enforcing the data to be migrated, then wouldn't it be sensible enough 
to just do it at that point?

If I were to have a guess at that reason I would say it is that you can 
do this command live without taking nova api offline whereas migrations 
are generally done as downtime and this could be a long migration.

Cheers,
Josh

Rackspace Australia

On 4/21/15 4:52 PM, Michael Still wrote:
> Hey, turbo hipster already knows how to upgrade major releases, so
> adding this should be possible.
>
> That said, I've been travelling all day so haven't had a chance to
> look at this. If Josh doesn't beat me to it, I will take a look when I
> get to my hotel tonight.
>
> (We should also note that we can just merge a thing without turbo
> hipster passing if we understand the reason for the test failure.
> Sure, that breaks the rest of the turbo hipster runs, but we're not
> 100% blocked here.)
>
> Michael
>
> On Tue, Apr 21, 2015 at 12:09 AM, Dan Smith <dms at danplanet.com> wrote:
>> This proposed patch requiring a data migration in Nova master is making
>> Turbo Hipster face plant - https://review.openstack.org/#/c/174480/
>>
>> This is because we will require Kilo deployers to fully migrate their
>> flavor data from system_metadata to instance_extra before they upgrade
>> to the next release. They (and turbo hipster) will need to do this first:
>>
>> https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L963
>>
>> I'm not sure how you want to handle this, either by converting your data
>> sets, or only converting the ones that master runs.
>>
>> It would be nice to merge this patch as soon as grenade is ready to do
>> so, as it's blocking all other db migrations in master.
>>
>> Thanks!
>>
>> --Dan
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>