Open Stack

On Thu, Sep 11, 2014 at 8:32 AM, James E. Blair <corvus at inaugust.com> wrote:

> James Polley <jp at jamezpolley.com> writes:
>
> > On Thu, Sep 11, 2014 at 6:52 AM, James E. Blair <corvus at inaugust.com>
> wrote:
> >
> >> Steven Hardy <shardy at redhat.com> writes:
> >>
> >> > Yeah, I don't know what the optimal solution is - my attention has
> >> recently
> >> > been drawn to queries generated via gerrit-dash-creator, which I'm
> >> finding
> >> > help a lot.
> >>
> >> This is one of several great solutions to the problem.  Any query in
> >> Gerrit can include an age specifier.  To get the old behavior, just add
> >> "age:-2week" (that translates to "last updated less than 2 weeks ago")
> >> to any query -- whether a dashboard or your own bookmarked query like
> >> this one:
> >>
> >>
> >>
> https://review.openstack.org/#/q/status:open+age:-2week+project:openstack/nova,n,z
> >
> >
> > If someone uploads a patch, and 15 days later it's had no comments at
> all,
> > would it be visible in this query? My understanding is that it wouldn't,
> as
> > it was last updated more than two weeks ago
> >
> > In my mind, a patch that's had no comments in two weeks should be high on
> > the list of thing that need feedback. As far as I know, Gerrit doesn't
> have
> > any way to sort by oldest-first though, so even if a two-week-old patch
> was
> > visible in the query, it would be at the bottom of the list.
>
> Indeed, however, a slightly different query will get you exactly what
> you're looking for.  This will show changes that are at least 2 days
> old, have no code reviews, are not WIP, and have passed Jenkins:
>
>   project:openstack/nova status:open label:Verified>=1,jenkins NOT
> label:Workflow<=-1 NOT label:Code-Review<=2 age:2d
>
> or the direct link:
>
>
> https://review.openstack.org/#/q/project:openstack/nova+status:open+label:Verified%253E%253D1%252Cjenkins+NOT+label:Workflow%253C%253D-1+NOT+label:Code-Review%253C%253D2+age:2d,n,z


Weeks later I finally went to add this to our dashboard, only to find that
we already have something similar, if I'm reading correctly.

http://git.openstack.org/cgit/stackforge/gerrit-dash-creator/tree/dashboards/tripleo.dash#n15

[section "5 Days Without Feedback"]
query = label:Verified>=1%2cjenkins NOT owner:self NOT
project:openstack/tripleo-specs NOT label:Code-Review<=2 age:5d


(plus the other qualifiers added in the header: status:open NOT
label:Workflow<=-1 NOT label:Code-Review<=-2)

This particular section is okay right now - only one change visible. The
"Needs Approval" section (query = label:Verified>=1%2cjenkins NOT
owner:self label:Code-Review>=2 NOT label:Code-Review-1) is more of a
problem; 43 reviews, with the oldest hidden at the bottom.

I can see a few ways I could improve this; one would be to to split "Needs
approval" into multiple sections - "Needs Approval" for 0-5 days, "Really
needs approval" for 5-10, and so on. Another would be to add something to
enable oldest-first sorting in Gerrit. I'm thinking that it doesn't even
need to be server-side, a client-side script (just like the one that adds
the "Toggle CI" button) would probably suffice to enable the sorting.

If anyone has other ideas before I start tinkering with jquery to make the
tables sortable, I'd love to hear it - but from my limited experience with
jquery I don't think it should be too much of an issue.


>
>
> Incidentally, that is the query in the "Wayward Changes" section of the
> "Review Inbox" dashboard (thanks Sean!); for nova, you can see it here:
>
>
> https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard
>
> The key here is that there are a lot of changes in a lot of different
> states, and one query isn't going to do everything that everyone wants
> it to do.  Gerrit has a _very_ powerful query language that can actually
> help us make sense of all the changes we have in our system without
> externalizing the cost of that onto contributors in the form of
> forced-abandoning of changes.  Dashboards can help us share the
> knowledge of how to get the most out of it.
>
>   https://review.openstack.org/Documentation/user-dashboards.html
>   https://review.openstack.org/Documentation/user-search.html
>
> -Jim
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140926/0b378ab9/attachment.html>