[openstack-dev] [neutron] [infra] Python 2.6 tests can't possibly be passing in neutron

Kevin L. Mitchell kevin.mitchell at rackspace.com
Mon Sep 22 17:58:04 UTC 2014


On Mon, 2014-09-22 at 10:32 -0700, Armando M. wrote:
> What about:
> 
> https://github.com/openstack/neutron/blob/master/test-requirements.txt#L12

Pulling in ordereddict doesn't do anything if your code doesn't use it
when OrderedDict isn't in collections, which is the case here.  Further,
there's no reason that _get_collection_kwargs() needs to use an
OrderedDict: it's initialized in an arbitrary order (generator
comprehension over a set), then later passed to functions with **, which
converts it to a plain old dict.
-- 
Kevin L. Mitchell <kevin.mitchell at rackspace.com>
Rackspace




More information about the OpenStack-dev mailing list