On Fri, Sep 19, 2014 at 8:59 AM, Donald Stufft <donald at stufft.io> wrote: > > On Sep 19, 2014, at 11:54 AM, Brant Knudson <blk at acm.org> wrote: > > > I don't think anyone would be complaining if glanceclient didn't have the > need to reach into and monkeypatch requests's connection pool manager[1]. > Is there a way to tell requests to build the https connections differently > without monkeypatching urllib3.poolmanager? > > glanceclient's monkeypatching of the global variable here is dangerous > since it will mess with the application and every other library if the > application or another library uses glanceclient. > > [1] > http://git.openstack.org/cgit/openstack/python-glanceclient/tree/glanceclient/common/https.py#n75 > > > Why does it need to use it’s own VerifiedHTTPSConnection class? Ironically > reimplementing that is probably more dangerous for security than requests > bundling urllib3 ;) > We supported the option to skip SSL compression since before adopting requests (see 556082cd6632dbce52ccb67ace57410d61057d66), useful when uploading already compressed images. > > --- > Donald Stufft > PGP: 7C6B 7C5D 5E2B 6356 A926 F04F 6E3C BCE9 3372 DCFA > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev at lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140919/fbdd2d3c/attachment.html>