Open Stack

On 18 Sep 2014, at 6:06 pm, Sullivan, Jon Paul <JonPaul.Sullivan at hp.com> wrote:

>> -----Original Message-----
>> From: James E. Blair [mailto:corvus at inaugust.com]
>> Sent: 17 September 2014 23:24
>> To: OpenStack Development Mailing List (not for usage questions)
>> Subject: Re: [openstack-dev] [TripleO] Set WIP for stale patches?
>> 
>> "Sullivan, Jon Paul" <JonPaul.Sullivan at hp.com> writes:
>> 
>>> I think this highlights exactly why this should be an automated
>>> process.  No errors in application, and no errors in interpretation of
>>> what has happened.
>>> 
>>> So the -1 from Jenkins was a reaction to the comment created by adding
>>> the workflow -1.  This is going to happen on all of the patches that
>>> have their workflow value altered (tests will run, result would be
>>> whatever the result of the test was, of course).
>> 
>> Jenkins only runs tests in reaction to comments if they say "recheck".
> 
> This is not my experience.
> 
> In my experience if the check results are not fresh enough the recheck is automatically run.  I am not on the infra team, so without looking up code I am just guessing, but my guess is that the workflow score change triggers the check on the presumption that it has been approved, not accounting for the recent(ish) update that move wip to the workflow score.
>    
>> 
>>> But I also agree that the Jenkins vote should not be included in the
>>> determination of marking a patch WIP, but a human review should (So
>>> Code-Review and not Verified column).
>>> 
>>> And in fact, for the specific example to hand, the last Jenkins vote
>>> was actually a +1, so as I understand it should not have been marked
>>> WIP.
>> 
>> I'd like to help you see the reviews you want to see without
>> externalizing your individual workflow onto contributors.  What tool do
>> you use to find reviews?
>> 
>> If it's gerrit's webui, have you tried using the Review Inbox dashboard?
>> Here it is for the tripleo-image-elements project:
>> 
>>  https://review.openstack.org/#/projects/openstack/tripleo-image-
>> elements,dashboards/important-changes:review-inbox-dashboard
>> 
>> If you would prefer something else, we can customize those dashboards to
>> do whatever you want, including ignoring changes that have not been
>> updated in 2 weeks.
> 
> This is not solely about finding reviews.  It is about pruning stale reviews.  I think the auto-abandon code was excellent at doing this, but alas, it is no more. 

The only reason i'm aware of for pruning apparently stale reviews is to make it easier to find and review things that are being actively worked on.

Do you have other reasons for wanting stale reviews pruned?
> 
>> 
>> -Jim
>> 
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> Thanks, 
> Jon-Paul Sullivan ☺ Cloud Services - @hpcloud
> 
> Postal Address: Hewlett-Packard Galway Limited, Ballybrit Business Park, Galway.
> Registered Office: Hewlett-Packard Galway Limited, 63-74 Sir John Rogerson's Quay, Dublin 2. 
> Registered Number: 361933
> 
> The contents of this message and any attachments to it are confidential and may be legally privileged. If you have received this message in error you should delete it from your system immediately and advise the sender.
> 
> To any recipient of this message within HP, unless otherwise stated, you should consider this message and attachments as "HP CONFIDENTIAL".
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev