Open Stack

So, that's your three. This exception is approved.

Michael

On Thu, Sep 4, 2014 at 9:05 AM, Nikola Đipanov <ndipanov at redhat.com> wrote:
> On 09/04/2014 03:46 PM, Daniel P. Berrange wrote:
>> On Thu, Sep 04, 2014 at 02:09:26PM +0100, Matthew Booth wrote:
>>> I'd like to request a FFE for the remaining changes from
>>> vmware-spawn-refactor. They are:
>>>
>>> https://review.openstack.org/#/c/109754/
>>> https://review.openstack.org/#/c/109755/
>>> https://review.openstack.org/#/c/114817/
>>> https://review.openstack.org/#/c/117467/
>>> https://review.openstack.org/#/c/117283/
>>>
>>> https://review.openstack.org/#/c/98322/
>>>
>>> All but the last had +A, and were in the gate at the time it was closed.
>>> The last had not yet been approved, but is ready for core review. It has
>>> recently had some orthogonal changes split out to simplify it
>>> considerably. It is largely a code motion patch, and has been given +1
>>> by VMware CI multiple times.
>>
>> They're all internal to the VMWare driver, have multiple ACKs from VMWare
>> maintainers as well as core, so don't require extra review time. So I think
>> it is reasonable request.
>>
>> ACK, I'll sponsor it.
>>
>
> +1 here - I've already looked at a number of those.
>
> N.
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



-- 
Rackspace Australia