Open Stack

> -----Original Message-----
> From: Sean Dague [mailto:sean at dague.net]
> Sent: 03 September 2014 13:37
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: [openstack-dev] [all] [glance] do NOT ever sort requirements.txt
> 
> I'm not sure why people keep showing up with "sort requirements" patches
> like - https://review.openstack.org/#/c/76817/6, however, they do.
> 
> All of these need to be -2ed with predjudice.
> 
> requirements.txt is not a declarative interface. The order is important as pip
> processes it in the order it is. Changing the order has impacts on the overall
> integration which can cause wedges later.
> 
> So please stop.
> 
> 	-Sean
> 
> --
> Sean Dague
> http://dague.net
>

Hi Sean & all,

Could you please open this up a little bit? What are we afraid breaking regarding the order of these requirements? I tried to go through pip documentation but I could not find reason of specific order of the lines, references to keep the order there was 'though.

I'm now assuming one thing here as I do not know if that's the case. None of the packages enables/disables functionality depending of what has been installed on the system before, but they have their own dependencies to provide those. Based on this assumption I can think of only one scenario causing us issues. That is us abusing the example in point 2 of https://pip.pypa.io/en/latest/user_guide.html#requirements-files meaning; we install package X depending on package Y>=1.0,<2.0 before installing package Z depending on Y>=1.0 to ensure that package Y<2.0 without pinning package Y in our requirements.txt. I certainly hope that this is not the case as depending 3rd party vendor providing us specific version of dependency package would be extremely stupid.

Other than that I really don't know how the order could cause us issues, but I would be really happy to learn something new today if that is the case or if my assumption went wrong.

Best Regards,
Erno (jokke_) Kuvaja
 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev