[openstack-dev] [nova] why do we have os-attach-interfaces in the v3 API?

Vishvananda Ishaya vishvananda at gmail.com
Fri Oct 3 16:11:11 UTC 2014


If you can add and delete interfaces it seems like being able to list them is useful. You can get the info you need from the networks list when you get the instance, but “nova interface-list” seems like a useful addition if we have “interface-attach” and “interface-detach”, so in this case I think I would suggest that we leave the proxying in and implement it for nova-network as well.

I was looking for an anologue with cinder but it looks like we have a volume-attach and volume-detach there without a volume-list <server> command so if people want to kill it I’m ok with that too.

Vish

On Oct 2, 2014, at 2:43 PM, Matt Riedemann <mriedem at linux.vnet.ibm.com> wrote:

> 
> 
> On 10/2/2014 4:34 PM, Vishvananda Ishaya wrote:
>> os-attach-interfacees is actually a a forward port of:
>> 
>> http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/contrib/attach_interfaces.py
>> 
>> which is a compute action that is valid for both nova-network and neutron:
>> 
>> http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/api.py#n2991
>> 
>> On Oct 2, 2014, at 1:57 PM, Matt Riedemann <mriedem at linux.vnet.ibm.com> wrote:
>> 
>>> The os-interface (v2) and os-attach-interfaces (v3) APIs are only used for the neutron network API, you'll get a NotImplemented if trying to call the related methods with nova-network [1].
>>> 
>>> Since we aren't proxying to neutron in the v3 API (v2.1), why does os-attach-interfaces [2] exist?  Was this just an oversight?  If so, please allow me to delete it. :)
>>> 
>>> [1] http://git.openstack.org/cgit/openstack/nova/tree/nova/network/api.py?id=2014.2.rc1#n310
>>> [2] http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/compute/plugins/v3/attach_interfaces.py?id=2014.2.rc1
>>> 
>>> --
>>> 
>>> Thanks,
>>> 
>>> Matt Riedemann
>>> 
>>> 
>>> _______________________________________________
>>> OpenStack-dev mailing list
>>> OpenStack-dev at lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> 
> 
> OK so create/delete call the compute_api to attach/detach, but show and index are calling the network_api on port methods which are neutron only, so I guess that's what I'm talking about as far as removing. Personally I don't think it hurts anything, but I'm getting mixed signals about the stance on neutron proxying in the v2.1 API.
> 
> -- 
> 
> Thanks,
> 
> Matt Riedemann
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20141003/9f8a5068/attachment.pgp>


More information about the OpenStack-dev mailing list