[openstack-dev] [nova] Proposal new hacking rules

Alexis Lee alexisl at hp.com
Mon Nov 24 15:01:45 UTC 2014

Matthew Gilliard said on Mon, Nov 24, 2014 at 02:50:08PM +0000:
> 1/ assertFalse() vs assertEqual(x, False) - these are semantically
> different because of python's notion of truthiness, so I don't think
> we ought to make this a rule.
> 2/ expected/actual - I don't see any reason not to try to improve
> in this area, even if it's difficult to automate.
> 3/ warn{ing} - https://github.com/openstack/nova/blob/master/nova/hacking/checks.py#L322
    "N331: Use LOG.warning due to compatibility with py3"
> Linus' post on this from the LKML is almost a decade old (!) but worth reading.
> https://lkml.org/lkml/2004/12/20/255

+1 on all points.

Nova Engineer, HP Cloud.  AKA lealexis, lxsli.

More information about the OpenStack-dev mailing list