[openstack-dev] [all] testtools 1.2.0 release breaks the world
sean at dague.net
Mon Nov 17 11:09:54 UTC 2014
On 11/16/2014 06:11 PM, Robert Collins wrote:
> On 17 November 2014 11:29, Alan Pevec <apevec at gmail.com> wrote:
>> 2014-11-15 23:06 GMT+01:00 Robert Collins <robertc at robertcollins.net>:
>>> We did find a further issue, which was due to the use of setUpClass in
>>> tempest (a thing that testtools has never supported per se - its
>>> always been a happy accident that it worked). I've hopefully fixed
>>> that in 1.3.0 and we're babysitting tempest now to see.
>> Trove stable/juno py26 (py27 works) unit tests are failing with testtools 1.3.0
>> File "/home/jenkins/workspace/periodic-trove-python26-juno/trove/tests/unittests/mgmt/test_models.py",
>> line 60, in setUpClass
>> super(MockMgmtInstanceTest, cls).setUpClass()
>> AttributeError: 'super' object has no attribute 'setUpClass'
>> pip freeze diff since last good report is:
>> Any ideas?
> The use of unittest2 in the plumbing means we're now calling
> setUpClass on 2.6 which we were not doing before.
> However there is no implementation of setUpClass in the testtools base
> class, which leads to the error you are seeing.
> We can fix that by subclassing unittest2.TestCase in testtools'
> TestCase. I'll put a patch together today.
We don't support 2.6 any more in OpenStack. If we decide to pin
testtools on stable/*, we could just let this be.
Fixing it is also fine. But I wouldn't mind just moving on here and
letting the 2.6 bits die with vigor.
More information about the OpenStack-dev