[openstack-dev] [oslo][context] oslo.context repository review request

Julien Danjou julien at danjou.info
Thu Nov 6 10:44:09 UTC 2014

On Thu, Nov 06 2014, Doug Hellmann wrote:

> The main reasons for splitting code into its own library are dependency
> management, API ownership, the logical separation of the contents of the library
> within the application stack and between other libraries, and review ACLs within
> gerrit.
> We have a couple of libraries (oslo.log and oslo.messaging) that want to specify
> an API via the context base class, so the class can’t live in either of those
> places.
> The utils library is actually used by some of the clients now, so we need to be
> conscious of adding dependencies there. I don’t think context will bring in any
> real dependencies for now, but it also doesn’t seem to be a general-purpose
> utility. We’re going to need to add some thread-local caches for setting and
> fetching the current context, I think, either within context or in some of the
> other libraries with callbacks invoked by the context constructor. So for
> logical separation, a different library seemed to make more sense.
> It’s also possible that the applications will find other uses for a shared
> context base class, and so we’ll want to build a review team for it that isn’t
> limited to the oslo-core team, but that’s less important than the logical
> considerations in my mind.

Ok, I can agree with all of that.

I'm just not sure the burden of having yet another lib/repo/team is
worth it for this lib. But you seem pretty confident about it and I
don't have any massive objection.

(And anyway I'll still have this mailing list thread to refer in a few
months for an I-told-you-so just in case. :-)

So that repo LGTM dims.

Julien Danjou
;; Free Software hacker
;; http://julien.danjou.info
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20141106/e4f1a703/attachment.pgp>

More information about the OpenStack-dev mailing list