[openstack-dev] [oslo][context] oslo.context repository review request
Davanum Srinivas
davanum at gmail.com
Wed Nov 5 16:09:58 UTC 2014
jd__,
No issues. I followed the process in the wiki for creating a library
with minimal changes required to get the test running as documented.
we can do some of these in the openstack git when the project gets
created.
Please see notes from Doug on the etherpad on why leaving it in
oslo.log or oslo.utils was not considered.
https://etherpad.openstack.org/p/kilo-oslo-library-proposals
Yes, i had the same concern about yet-another-oslo-lib concern!
thanks,
dims
On Wed, Nov 5, 2014 at 5:02 PM, Julien Danjou <julien at danjou.info> wrote:
> On Wed, Nov 05 2014, Davanum Srinivas wrote:
>
> Sorry I missed the session (had a talk at that time).
>
>> At the Design Summit session for Oslo Library Graduation for Kilo, we
>> decided that oslo.context was a high priority item since oslo.log was
>> blocked. So here's a git repo [2], please take a look to see if this
>> is good enough for us to open up a infra request.
>
> A few comments, considering that:
>
> - https://github.com/dims/oslo.context/blob/master/oslo/context/context.py#L28
> should switch to use oslo.utils.uuidutils to generate the UUID.
> - The list of dependency is very short
> - oslo.log (will) depends on oslo.utils
> - oslo.log is the only user of that (out of the projects themselves)
>
> What about just moving this into oslo.log or oslo.utils?
>
> That would avoid the burden of having yet-another-lib for a 100 SLOC
> long file.
>
> --
> Julien Danjou
> # Free Software hacker
> # http://julien.danjou.info
--
Davanum Srinivas :: https://twitter.com/dims
More information about the OpenStack-dev
mailing list