Open Stack

On 28 May 2014, at 13:51, Angus Salkeld <angus.salkeld at RACKSPACE.COM> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 17/05/14 02:48, W Chan wrote:
>> Regarding config opts for keystone, the keystoneclient middleware already 
>> registers the opts at 
>> https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L325 
>> under a keystone_authtoken group in the config file.  Currently, Mistral 
>> registers the opts again at 
>> https://github.com/stackforge/mistral/blob/master/mistral/config.py#L108 under a 
>> different configuration group.  Should we remove the duplicate from Mistral and 
>> refactor the reference to keystone configurations to the keystone_authtoken 
>> group?  This seems more consistent.
> 
> I think that is the only thing that makes sense. Seems like a bug
> waiting to happen having the same options registered twice.
> 
> If some user used to other projects comes and configures
> "keystone_authtoken" then will their config take effect?
> (how much confusion will that generate)..
> 
> I'd suggest just using the one that is registered keystoneclient.

Ok, I had a feeling it was needed for some reason. But after having another look at this I think this is really a bug. Let’s do it.

Thanks guys