Open Stack

The patch in question is doing an invasive runtime check [1] to determine whether arp header modification is supported by ovs.  I seem to remember a lack of consensus on whether invasive runtime checks were acceptable around vxlan detection, and I would appreciate confirmation from other cores that this approach is considered acceptable for this patch.


m.

1: https://review.openstack.org/#/c/49227/41/neutron/agent/linux/ovs_lib.py

On May 19, 2014, at 1:07 PM, Assaf Muller <amuller at redhat.com> wrote:

> Hello Mark, Bob and Kyle,
> 
> You've all been involved with the OVS ARP responder patch:
> https://review.openstack.org/#/c/49227/
> 
> I kindly request that you revisit this patch - It's ready from
> my point of view, if that means anything. The last few patchsets
> have been nitpicks. Looking at the history, the patch has already
> had a large amount of +1's and +2's through it's various stages.
> 
> I think it'd be technically superior if this patch was merged
> before further progress is made in the DVR patch series.
> 
> 
> Thanks for your time,
> Assaf Muller, Cloud Networking Engineer
> Red Hat