Open Stack

*@Christian,*

> According to http://legacy.python.org/dev/peps/pep-0352/ the message
> attribute of BaseException is deprecated since Python 2.6 and was
> dropped in Python 3.0.

Some projects have custom exception hierarchy, with strictly defined
attributes
(e.g. message, or something else). In a previous mail, I mean exactly that
case,
not the case with a built-in exceptions.


*@Joshua, *

> Any reason we would want to do this vs using exc_info=True?

1. It will print traceback and it's not behavior we always want.
2. It doesn't handle unicode. I mean, we may have something like this in
our output:
  \u043f\u0440\u0438\u0432\u0435\u0442



On Fri, May 16, 2014 at 5:19 AM, Joshua Harlow <harlowja at yahoo-inc.com>wrote:

>  Any reason we would want to do this vs using exc_info=True?
>
>  This leaves it up to the underlying logger to dump the exception, the
> traceback and whatever else.
>
>  For example u can do.
>
>  >>> LOG.warn("Something broke at this point", exc_info=True)
>
>   From: Igor Kalnitsky <ikalnitsky at mirantis.com>
> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <
> openstack-dev at lists.openstack.org>
> Date: Thursday, May 15, 2014 at 2:20 PM
> To: "OpenStack Development Mailing List (not for usage questions)" <
> openstack-dev at lists.openstack.org>
> Subject: Re: [openstack-dev] [oslo] Logging exceptions and Python 3
>
>    Hi,
>
>  > Is there a reason to log the exception as Unicode on Python 2?
>
>  Sure, why not? Some exceptions may have unicode message with non-ASCII
> characters. and we obviously can't cast such exceptions with str() in
> Python 2.x.
>
>
>  > The problem is that I don't know what is the best syntax to log
> exceptions.
>
>  I hate this unicode dances too, since I don't understand all nuances and
> potential pitfalls. But I belive the better approach is to use unicode()
> for Python 2.x and str() for Python 3.x.
>
>  Example:
>
>      LOG.error(six.text_type(e))
>
>
>  P.S: I've a quick look over logging implementaion, and figured out
> that it has some code to dial with unicode. In few words, if we know
> about exception's attributes, it's better to use it directly to log:
>
>  Example:
>
>      LOG.error(e.message)
>
>
>  - Igor
>
>
> On Thu, May 15, 2014 at 6:29 PM, Victor Stinner <
> victor.stinner at enovance.com> wrote:
>
>> Hi,
>>
>> I'm trying to define some rules to port OpenStack code to Python 3. I just
>> added a section in the "Port Python 2 code to Python 3" about formatting
>> exceptions and the logging module:
>>
>> https://wiki.openstack.org/wiki/Python3#logging_module_and_format_exceptions
>>
>> The problem is that I don't know what is the best syntax to log
>> exceptions.
>> Some projects convert the exception to Unicode, others use str(). I also
>> saw
>> six.u(str(exc)) which is wrong IMO (it can raise unicode error if the
>> message
>> contains a non-ASCII character).
>>
>> IMO the safest option is to use str(exc). For example, use
>> LOG.debug(str(exc)).
>>
>> Is there a reason to log the exception as Unicode on Python 2?
>>
>> Victor
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140516/bfd847bf/attachment.html>