Open Stack

On 05/11/2014 10:26 AM, Mark McLoughlin wrote:
> On Fri, 2014-05-09 at 08:20 -0400, Sean Dague wrote:
>> Based on some of my blog posts on gerrit queries, I've built and gotten
>> integrated a custom inbox zero dashboard which is per project in gerrit.
>>
>> ex:
>> https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard
>>
>> (replace openstack/nova with the project of your choice).
>>
>> This provides 3 sections.
>>
>> = Needs Final +2 =
>>
>> This is code that has an existing +2, no negative code review feedback,
>> and positive jenkins score. So it's mergable if you provide the final +2.
>>
>> (Gerrit Query: status:open NOT label:Code-Review>=0,self
>> label:Verified>=1,jenkins NOT label:Code-Review<=-1 label:Code-Review>=2
>> NOT label:Workflow<=-1 limit:50 )
>>
>> = No negative feedback =
>>
>> Changes that have no negative code review feedback, and positive jenkins
>> score.
>>
>> (Gerrit Query: status:open NOT label:Code-Review>=0,self
>> label:Verified>=1,jenkins NOT label:Code-Review<=-1 NOT
>> label:Workflow<=-1 limit:50 )
>>
>> = Wayward changes =
>>
>> Changes that have no code review feedback at all (no one has looked at
>> it), a positive jenkins score, and are older than 2 days.
>>
>> (Gerrit Query: status:open label:Verified>=1,jenkins NOT
>> label:Workflow<=-1 NOT label:Code-Review<=2 age:2d)
>>
>>
>> In all cases it filters out patches that you've commented on in the most
>> recently revision. So as you vote on these things they will disappear
>> from your list.
>>
>> Hopefully people will find this dashboard also useful.
> 
> Nicely done. Any reason you've included the stable branches - i.e. not
> restricted it to branch:master ?

Because it hadn't quite occurred to me yet to filter it out. I think
that would be a good change. Joe also mentioned filtering out things you
own: NOT owner:self. Which I also think would be a good change.

The processing of changing these is currently a little odd because of
where they live in the gerrit meta data. I'm hoping we can get this into
a normal code review flow in the next couple of weeks and get these
changes in, as well making it easy to get people to add new additional
dashboards as well.

	-Sean

-- 
Sean Dague
http://dague.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140512/dd8da282/attachment.pgp>