Open Stack

There are a lot of 3rd party CI systems, and strictly speaking projects
only need to pass jenkins to make it through, so I don't think that's
fundamentally something we want to add here.

There is some ability to create per project dashboards as well, if you
wanted to build something just for trove in the trove repository.
Documentation on custom dashboards is here -
https://review.openstack.org/Documentation/user-dashboards.html

Realize that every project is going to have a class of concerns, so
these are attempting to be generically applicable rules that would apply
anywhere, and highlight code that's basically waiting on reviewers, not
waiting on the authors to take an action.

	-Sean

On 05/09/2014 08:42 AM, Doug Shelley wrote:
> Sean,
> 
> Very cool - thanks for providing. One question - for Trove, we have Jenkins but also voting jobs on reddwarf - any way to change the "No Negative Feedback" section to take into account reddwarf failures?
> 
> Regards,
> Doug
> 
> -----Original Message-----
> From: Sean Dague [mailto:sean at dague.net] 
> Sent: May-09-14 8:21 AM
> To: OpenStack Development Mailing List (not for usage questions)
> Subject: [openstack-dev] [all] custom gerrit dashboard - per project review inbox zero
> 
> Based on some of my blog posts on gerrit queries, I've built and gotten integrated a custom inbox zero dashboard which is per project in gerrit.
> 
> ex:
> https://review.openstack.org/#/projects/openstack/nova,dashboards/important-changes:review-inbox-dashboard
> 
> (replace openstack/nova with the project of your choice).
> 
> This provides 3 sections.
> 
> = Needs Final +2 =
> 
> This is code that has an existing +2, no negative code review feedback, and positive jenkins score. So it's mergable if you provide the final +2.
> 
> (Gerrit Query: status:open NOT label:Code-Review>=0,self label:Verified>=1,jenkins NOT label:Code-Review<=-1 label:Code-Review>=2 NOT label:Workflow<=-1 limit:50 )
> 
> = No negative feedback =
> 
> Changes that have no negative code review feedback, and positive jenkins score.
> 
> (Gerrit Query: status:open NOT label:Code-Review>=0,self label:Verified>=1,jenkins NOT label:Code-Review<=-1 NOT
> label:Workflow<=-1 limit:50 )
> 
> = Wayward changes =
> 
> Changes that have no code review feedback at all (no one has looked at it), a positive jenkins score, and are older than 2 days.
> 
> (Gerrit Query: status:open label:Verified>=1,jenkins NOT
> label:Workflow<=-1 NOT label:Code-Review<=2 age:2d)
> 
> 
> In all cases it filters out patches that you've commented on in the most recently revision. So as you vote on these things they will disappear from your list.
> 
> Hopefully people will find this dashboard also useful.
> 
> 	-Sean
> 
> --
> Sean Dague
> http://dague.net
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 


-- 
Sean Dague
http://dague.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140509/10081049/attachment.pgp>