Open Stack

On Mon, May 5, 2014 at 9:06 PM, David Stanek <dstanek at dstanek.com> wrote:
>
> On Mon, May 5, 2014 at 5:28 PM, Doug Hellmann <doug.hellmann at dreamhost.com>
> wrote:
>>
>>
>> > The assert ones do seem to fit the best practices as I understand them,
>> > but
>> > I suspect there's going to be quite a bit of work to get projects
>> > compliant.
>>
>> I've seen some work being done on that already, but I don't know how
>> strongly we care about those specific rules as an overall project.
>>
>
> I created the Keystone blueprint[1] to automate the things we already check
> for in reviews. My motivation was to make it faster for contributors to
> contribute because they would get feedback before getting a bunch of -1s in
> Gerrit. I also wanted to free up core dev resources so that we can focus on
> more important parts of reviews.

Sure, that makes sense to do in keystone.

>
> I'd be happy to start putting some of these in hacking, but I don't know
> which rules would be acceptable to all projects. Maybe there is a way to
> make optional checks that can be enabled in the tox.ini

This is the part I wasn't sure about. Some of the rules look pretty
useful (e.g., no mutable arguments). Others are more stylistic choices
(e.g., which type of quotes to use).

Joe Gordon drives the hacking project, and he might be able to give
more detail about the process for adding new rules there.

Doug

>
> 1.
> https://blueprints.launchpad.net/keystone/+spec/more-code-style-automation
>
> --
> David
> blog: http://www.traceback.org
> twitter: http://twitter.com/dstanek
> www: http://dstanek.com
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>