Open Stack

Hi David, Ken'ichi,

Thursday, May 1, 2014 1:02 PM Ken'ichi Ohmichi <ken1ohmichi at gmail.com>: 
>Hi David,

>2014-05-01 5:44 GMT+09:00 David Kranz <dkranz at redhat.com>:
>> There have been a lot of patches that add the validation of response dicts.
>> We need a policy on whether this is required or not. For example, this 
>> patch
>>
>> https://review.openstack.org/#/c/87438/5
>>
>> is for the equivalent of 'cinder service-list' and is a basically a 
>> copy of the nova test which now does the validation. So two questions:
>>
>> Is cinder going to do this kind of checking?
>> If so, should new tests be required to do it on submission?

>I'm not sure someone will add the similar validation, which we are adding to Nova API tests, to Cinder API tests also. but it would be nice for Cinder and Tempest. The validation can be applied to the other >projects(Cinder, etc) easily because the base framework is implemented in common rest client of Tempest.

Yes, that will be nice if we start implementing the validation part for other component's APIs test also. I can take this and start implementing the validation for existing tests of cinder. Those can be continue whenever new test cases are going to be added.

>When adding new tests like https://review.openstack.org/#/c/87438 , I don't have strong opinion for including the validation also. These schemas will be large sometimes and the combination in the same patch >would make reviews difficult. In current Nova API test implementations, we are separating them into different patches.

Me too agree.

Thanks
Ghanshyam Mann
_______________________________________________
OpenStack-dev mailing list
OpenStack-dev at lists.openstack.org
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



DISCLAIMER:
-----------------------------------------------------------------------------------------------------------------------
The contents of this e-mail and any attachment(s) are confidential and
intended
for the named recipient(s) only. 
It shall not attach any liability on the originator or NEC or its
affiliates. Any views or opinions presented in 
this email are solely those of the author and may not necessarily reflect the
opinions of NEC or its affiliates. 
Any form of reproduction, dissemination, copying, disclosure, modification,
distribution and / or publication of 
this message without the prior written consent of the author of this e-mail is
strictly prohibited. If you have 
received this email in error please delete it and notify the sender
immediately. .
-----------------------------------------------------------------------------------------------------------------------