[openstack-dev] [Mistral] task update at end of handle_task in executor

W Chan m4d.coder at gmail.com
Thu Mar 27 03:46:04 UTC 2014


In addition, for sync tasks, it'll overwrite the task state from SUCCESS to
RUNNING.


On Wed, Mar 26, 2014 at 8:41 PM, Dmitri Zimine <dz at stackstorm.com> wrote:

> My understanding is: it's the engine which finalizes the task results,
> based on the status returned by the task via convey_task_result call.
>
>
> https://github.com/stackforge/mistral/blob/master/mistral/engine/abstract_engine.py#L82-L84
>
> https://github.com/stackforge/mistral/blob/master/mistral/engine/scalable/executor/server.py#L44-L66
>
> In case of async tasks, executor keeps the task status at RUNNING, and a
> 3rd party system will call convey_task_resutls on engine.
>
>
> https://github.com/stackforge/mistral/blob/master/mistral/engine/scalable/executor/server.py#L123
> ,
>
>
> This line however looks like a bug to me:  at best it doesnt do much and
> at worst it overwrites the ERROR previously set in here
> http://tinyurl.com/q5lps2h
>
> Nicolay, any better explanation?
>
>
> DZ>
>
> On Mar 26, 2014, at 6:20 PM, W Chan <m4d.coder at gmail.com> wrote:
>
> Regarding
> https://github.com/stackforge/mistral/blob/master/mistral/engine/scalable/executor/server.py#L123,
> should the status be set to SUCCESS instead of RUNNING?  If not, can
> someone clarify why the task should remain RUNNING?
>
> Thanks.
> Winson
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140326/581dcebf/attachment.html>


More information about the OpenStack-dev mailing list