[openstack-dev] [TripleO][reviews] We're falling behind

Chris Jones cmsj at tenshu.net
Tue Mar 25 20:56:19 UTC 2014


Hey

+1

3 a day seems pretty sustainable.

Cheers,
--
Chris Jones

> On 25 Mar 2014, at 20:17, Robert Collins <robertc at robertcollins.net> wrote:
> 
> TripleO has just seen an influx of new contributors. \o/. Flip side -
> we're now slipping on reviews /o\.
> 
> In the meeting today we had basically two answers: more cores, and
> more work by cores.
> 
> We're slipping by 2 reviews a day, which given 16 cores is a small amount.
> 
> I'm going to propose some changes to core in the next couple of days -
> I need to go and re-read a bunch of reviews first - but, right now we
> don't have a hard lower bound on the number of reviews we request
> cores commit to (on average).
> 
> We're seeing 39/day from the 16 cores - which isn't enough as we're
> falling behind. Thats 2.5 or so. So - I'd like to ask all cores to
> commit to doing 3 reviews a day, across all of tripleo (e.g. if your
> favourite stuff is all reviewed, find two new things to review even if
> outside comfort zone :)).
> 
> And we always need more cores - so if you're not a core, this proposal
> implies that we'll be asking that you a) demonstrate you can sustain 3
> reviews a day on average as part of stepping up, and b) be willing to
> commit to that.
> 
> Obviously if we have enough cores we can lower the minimum commitment
> - so I don't think this figure should be fixed in stone.
> 
> And now - time for a loose vote - who (who is a tripleo core today)
> supports / disagrees with this proposal - lets get some consensus
> here.
> 
> I'm in favour, obviously :), though it is hard to put reviews ahead of
> direct itch scratching, its the only way to scale the project.
> 
> -Rob
> 
> -- 
> Robert Collins <rbtcollins at hp.com>
> Distinguished Technologist
> HP Converged Cloud
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list