Open Stack

+1

I think there should be naming standard for all reviews (e.g. [test] Jenkins, [test-external] VMware) so that gerrit css can colorize automatic review comments no matter the project.


m.

On Mar 7, 2014, at 2:08 AM, Chmouel Boudjnah <chmouel at enovance.com> wrote:

> if peoples like this why don't we have it directly on the reviews?
> 
> Chmouel.
> 
> 
> On Tue, Mar 4, 2014 at 10:00 PM, Carl Baldwin <carl at ecbaldwin.net> wrote:
> Nachi,
> 
> Great!  I'd been meaning to do something like this.  I took yours and
> tweaked it a bit to highlight failed Jenkins builds in red and grey
> other Jenkins messages.  Human reviews are left in blue.
> 
> javascript:(function(){
>     list = document.querySelectorAll('td.GJEA35ODGC');
>     for(i in list) {
>         title = list[i];
>         if(! title.innerHTML) { continue; }
>         text = title.nextSibling;
>         if (text.innerHTML.search('Build failed') > 0) {
>             title.style.color='red'
>         } else if(title.innerHTML.search('Jenkins|CI|Ryu|Testing|Mine') >= 0) {
>             title.style.color='#666666'
>         } else {
>             title.style.color='blue'
>         }
>     }
> })()
> 
> Carl
> 
> On Wed, Feb 26, 2014 at 12:31 PM, Nachi Ueno <nachi at ntti3.com> wrote:
> > Hi folks
> >
> > I wrote an bookmarklet for neutron gerrit review.
> > This bookmarklet make the comment title for 3rd party ci as gray.
> >
> > javascript:(function(){list =
> > document.querySelectorAll('td.GJEA35ODGC'); for(i in
> > list){if(!list[i].innerHTML){continue;};if(list[i].innerHTML &&
> > list[i].innerHTML.search('CI|Ryu|Testing|Mine') >
> > 0){list[i].style.color='#666666'}else{list[i].style.color='red'}};})()
> >
> > enjoy :)
> > Nachi
> >
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev at lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev