[openstack-dev] [Nova] FFE request: clean-up-legacy-block-device-mapping
Russell Bryant
rbryant at redhat.com
Wed Mar 5 18:58:42 UTC 2014
On 03/05/2014 12:18 PM, Andrew Laski wrote:
> On 03/05/14 at 09:05am, Dan Smith wrote:
>>> Why accept it?
>>>
>>> * It's low risk but needed refactoring that will make the code that has
>>> been a source of occasional bugs.
>>> * It is very low risk internal refactoring that uses code that has been
>>> in tree for some time now (BDM objects).
>>> * It has seen it's fair share of reviews
>>
>> Yeah, this has been conflict-heavy for a long time. If it hadn't been, I
>> think it'd be merged by now.
>>
>> The bulk of this is done, the bits remaining have seen a *lot* of real
>> review. I'm happy to commit to reviewing this, since I've already done
>> so many times :)
>
> I will also commit to reviewing this as I have reviewed much of it already.
Ok great, consider it approved. It really needs to get in this week
though, with an absolute hard deadline of this coming Tuesday.
--
Russell Bryant
More information about the OpenStack-dev
mailing list