Hi Xu Han & Sean, Is this code going to be committed as it is? Based on this morning's discussion, I thought that the IP address used to install the RA rule comes from the qr-xxx interface's LLA address. I think that I'm confused. Also this bug: Allow LLA as router interface of IPv6 subnet https://review.openstack.org/76125 was created due to comments to 72252. If We don't need to create a new LLA for the gateway IP, is the fix still needed? Just trying to sync up with you guys on them. Thanks, Robert On 3/4/14 3:02 AM, "Sean M. Collins (Code Review)" <review at openstack.org> wrote: >Sean M. Collins has posted comments on this change. > >Change subject: Permit ICMPv6 RAs only from known routers >...................................................................... > > >Patch Set 4: Looks good to me, but someone else must approve > >Automatically re-added by Gerrit trivial rebase detection script. > >-- >To view, visit https://review.openstack.org/72252 >To unsubscribe, visit https://review.openstack.org/settings > >Gerrit-MessageType: comment >Gerrit-Change-Id: I1d5c7aaa8e4cf057204eb746c0faab2c70409a94 >Gerrit-PatchSet: 4 >Gerrit-Project: openstack/neutron >Gerrit-Branch: master >Gerrit-Owner: Xu Han Peng <xuhanp at cn.ibm.com> >Gerrit-Reviewer: Arista Testing <arista-openstack-test at aristanetworks.com> >Gerrit-Reviewer: Baodong (Robert) Li <baoli at cisco.com> >Gerrit-Reviewer: Big Switch CI <openstack-ci at bigswitch.com> >Gerrit-Reviewer: Brian Haley <brian.haley at hp.com> >Gerrit-Reviewer: Brocade CI <openstack_gerrit at brocade.com> >Gerrit-Reviewer: Cisco Neutron CI <cisco-openstack-neutron-ci at cisco.com> >Gerrit-Reviewer: Hyper-V CI <hyper-v_ci at microsoft.com> >Gerrit-Reviewer: Jenkins >Gerrit-Reviewer: Midokura CI Bot <lucas at midokura.com> >Gerrit-Reviewer: Miguel Angel Ajo <miguelangel at ajo.es> >Gerrit-Reviewer: NEC OpenStack CI <nec-openstack-ci at iaas.jp.nec.com> >Gerrit-Reviewer: Neutron Ryu <ryu-openstack-review at lists.sourceforge.net> >Gerrit-Reviewer: Nuage CI <nuage-ci at nuagenetworks.net> >Gerrit-Reviewer: One Convergence CI <oc-neutron-test at oneconvergence.com> >Gerrit-Reviewer: PLUMgrid CI <plumgrid-ci-os at plumgrid.com> >Gerrit-Reviewer: Sean M. Collins <sean_collins2 at cable.comcast.com> >Gerrit-Reviewer: Xu Han Peng <xuhanp at cn.ibm.com> >Gerrit-Reviewer: mark mcclain <mmcclain at yahoo-inc.com>