[openstack-dev] Neutron: Need help with tox failure in VPN code
linb at vmware.com
Tue Mar 4 06:31:50 UTC 2014
I don't know whether i got your point. But try to modify /neutron/tests/unit/services/vpn/test_vpnaas_driver_plugin.py like the following, the error would be fixed:
@@ -17,6 +17,7 @@
+from oslo.config import cfg
from neutron.common import constants
from neutron import context
@@ -44,6 +45,11 @@ class TestVPNDriverPlugin(test_db_vpnaas.TestVpnaas,
self.driver = mock.Mock()
self.driver.service_type = ipsec_driver.IPSEC
driver_cls.return_value = self.driver
+ vpnaas_provider = (p_constants.VPN +
+ 'service_drivers.ipsec.IPsecVPNDriver:default' )
+ [vpnaas_provider], 'service_providers')
----- Original Message -----
From: "Paul Michali" <pcm at cisco.com>
To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
Sent: Tuesday, March 4, 2014 1:28:48 PM
Subject: [openstack-dev] Neutron: Need help with tox failure in VPN code
I'm stuck and can use some guidance here…please!
I have a change set out for review that used the VPN Service Type Framework ( https://review.openstack.org/74144 ). Everything worked fine, passed Jenkins, etc.
Found out that the STF won't make it to I-3, so I removed the dependency from my change set and tried to modify the plugin.py file to use some STF logic (like LBaaS uses) to load the desired service driver that is specified as the default. Adjusted the code to no longer use provider info.
Well, in doing so, tox fails, and unfortunately there little info on the failure. This can be seen by running a subset of the tests, where 2 fail:
tox -e py27 -v -- neutron.tests.unit.services.vpn
only the name of a failing test case for one, and a mention of return code 10 on another and no other info on the failure reason. I didn't see this on a full tox run in my repo, but Jenkins failed and Akihiro noticed it too, in running the above subset of the suite (thanks!).
I've narrow it down a bit, but have no idea why it fails…
One, it seems to be some interaction between test_vpnaas_driver_plugin.py and the two service driver tests (cisco_ipsec.py and ipsec.py). I can remove either one of the service driver tests cases, and it will still fail with the other one (so even the reference code fails).
Two, if I change plugin.py to set self.driver to the reference device driver (as is done in the latest patch set) it works fine with all test cases.
Three, it seems to be a test only issue, because I can run devstack with the login I have in plugin.py, currently commented out in __init__(), and successfully load either the reference or cisco service driver, by changing neutron.conf.
It seems like I'm doing something wrong in the loading of the service driver, or using this implementation, is somehow interacting with the tests.
If anyone has ideas on what is wrong, or a better way to load the service driver, please let me know. I was thinking I could read and parse neutron.conf manually and then load the service driver, but there must be a better way!
PCM (Paul Michali)
MAIL pcm at cisco.com
IRC pcm_ ( irc.freenode.net )
GPG key 4525ECC253E31A83
Fingerprint 307A 96BB 1A4C D2C7 931D 8D2D 4525 ECC2 53E3 1A83
OpenStack-dev mailing list
OpenStack-dev at lists.openstack.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev