[openstack-dev] [openstack-php-sdk] stream wrapper patch

Jamie Hannaford jamie.hannaford at rackspace.com
Mon Jun 23 12:32:11 UTC 2014


This patch is currently in review:

https://review.openstack.org/#/c/99303/

The aim behind it was to unify the different stream wrappers into one class, in order to be a little more clearer and concise. One of the reservations that came up in the review comments was that this patch introduced a “step back in functionality”. But is this really the case? AFAIK the original StreamWrapperFS didn’t actually do anything when “rmdir” and “mkdir” were called. All this patch does is re-organize methods - it doesn’t actually touch functionality. Am I wrong here?

Jamie




Jamie Hannaford
Software Developer III - CH     [experience Fanatical Support]

Tel:    +41434303908
Mob:    +41791009767
        [Rackspace]



Rackspace International GmbH a company registered in the Canton of Zurich, Switzerland (company identification number CH-020.4.047.077-1) whose registered office is at Pfingstweidstrasse 60, 8005 Zurich, Switzerland. Rackspace International GmbH privacy policy can be viewed at www.rackspace.co.uk/legal/swiss-privacy-policy
-
Rackspace Hosting Australia PTY LTD a company registered in the state of Victoria, Australia (company registered number ACN 153 275 524) whose registered office is at Suite 3, Level 7, 210 George Street, Sydney, NSW 2000, Australia. Rackspace Hosting Australia PTY LTD privacy policy can be viewed at www.rackspace.com.au/company/legal-privacy-statement.php
-
Rackspace US, Inc, 5000 Walzem Road, San Antonio, Texas 78218, United States of America
Rackspace US, Inc privacy policy can be viewed at www.rackspace.com/information/legal/privacystatement
-
Rackspace Limited is a company registered in England & Wales (company registered number 03897010) whose registered office is at 5 Millington Road, Hyde Park Hayes, Middlesex UB3 4AZ.
Rackspace Limited privacy policy can be viewed at www.rackspace.co.uk/legal/privacy-policy
-
Rackspace Benelux B.V. is a company registered in the Netherlands (company KvK nummer 34276327) whose registered office is at Teleportboulevard 110, 1043 EJ Amsterdam.
Rackspace Benelux B.V privacy policy can be viewed at www.rackspace.nl/juridisch/privacy-policy
-
Rackspace Asia Limited is a company registered in Hong Kong (Company no: 1211294) whose registered office is at 9/F, Cambridge House, Taikoo Place, 979 King's Road, Quarry Bay, Hong Kong.
Rackspace Asia Limited privacy policy can be viewed at www.rackspace.com.hk/company/legal-privacy-statement.php
-
This e-mail message (including any attachments or embedded documents) is intended for the exclusive and confidential use of the individual or entity to which this message is addressed, and unless otherwise expressly indicated, is confidential and privileged information of Rackspace. Any dissemination, distribution or copying of the enclosed material is prohibited. If you receive this transmission in error, please notify us immediately by e-mail at abuse at rackspace.com and delete the original message. Your cooperation is appreciated.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140623/9342a6e0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image7370a1.JPG
Type: image/jpeg
Size: 3124 bytes
Desc: image7370a1.JPG
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140623/9342a6e0/attachment.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image04f303.JPG
Type: image/jpeg
Size: 990 bytes
Desc: image04f303.JPG
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140623/9342a6e0/attachment-0001.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image57af39.JPG
Type: image/jpeg
Size: 6844 bytes
Desc: image57af39.JPG
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140623/9342a6e0/attachment-0002.jpe>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image40bd38.JPG
Type: image/jpeg
Size: 1074 bytes
Desc: image40bd38.JPG
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140623/9342a6e0/attachment-0003.jpe>


More information about the OpenStack-dev mailing list